couchdb-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fdman...@apache.org
Subject git commit: Remove bad couch_db:close/1 call
Date Sat, 10 Dec 2011 19:27:01 GMT
Updated Branches:
  refs/heads/master 1aafbf4b3 -> 8b9495158


Remove bad couch_db:close/1 call

This is unnecessary as the changes feed loop will do
the necessary database close once it starts waiting
for database update events. Plus, this close call
will fail when the database is deleted - this causes
sporadic replicator_db.js test failures.


Project: http://git-wip-us.apache.org/repos/asf/couchdb/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb/commit/8b949515
Tree: http://git-wip-us.apache.org/repos/asf/couchdb/tree/8b949515
Diff: http://git-wip-us.apache.org/repos/asf/couchdb/diff/8b949515

Branch: refs/heads/master
Commit: 8b9495158bc032186d946a4359735562c4d22474
Parents: 1aafbf4
Author: Filipe David Borba Manana <fdmanana@apache.org>
Authored: Sat Dec 10 18:44:40 2011 +0000
Committer: Filipe David Borba Manana <fdmanana@apache.org>
Committed: Sat Dec 10 19:26:26 2011 +0000

----------------------------------------------------------------------
 .../src/couch_replicator_manager.erl               |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/couchdb/blob/8b949515/src/couch_replicator/src/couch_replicator_manager.erl
----------------------------------------------------------------------
diff --git a/src/couch_replicator/src/couch_replicator_manager.erl b/src/couch_replicator/src/couch_replicator_manager.erl
index 3d31fa8..087c2c7 100644
--- a/src/couch_replicator/src/couch_replicator_manager.erl
+++ b/src/couch_replicator/src/couch_replicator_manager.erl
@@ -255,8 +255,7 @@ changes_feed_loop() ->
                 (_, _) ->
                     ok
                 end
-            ),
-            couch_db:close(Db)
+            )
         end
     ),
     {Pid, RepDbName}.


Mime
View raw message