couchdb-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rand...@apache.org
Subject svn commit: r1133561 - /couchdb/trunk/src/couchdb/couch_replicator.erl
Date Wed, 08 Jun 2011 21:30:03 GMT
Author: randall
Date: Wed Jun  8 21:30:03 2011
New Revision: 1133561

URL: http://svn.apache.org/viewvc?rev=1133561&view=rev
Log:
let dbs be closed implicitly when replication dies

We have the supervision tree and monitoring set up with ref counter.
There's really no need to call close here and it generates log noise
when a user DELETEs a local DB involved in replication unless we track
what happened and doing some nil-ing or special casing. Just letting it
all be implicit seems easiest. Closes COUCHDB-863.

Modified:
    couchdb/trunk/src/couchdb/couch_replicator.erl

Modified: couchdb/trunk/src/couchdb/couch_replicator.erl
URL: http://svn.apache.org/viewvc/couchdb/trunk/src/couchdb/couch_replicator.erl?rev=1133561&r1=1133560&r2=1133561&view=diff
==============================================================================
--- couchdb/trunk/src/couchdb/couch_replicator.erl (original)
+++ couchdb/trunk/src/couchdb/couch_replicator.erl Wed Jun  8 21:30:03 2011
@@ -478,9 +478,7 @@ terminate(Reason, State) ->
 terminate_cleanup(State) ->
     couch_task_status:update("Finishing"),
     stop_db_compaction_notifier(State#rep_state.source_db_compaction_notifier),
-    stop_db_compaction_notifier(State#rep_state.target_db_compaction_notifier),
-    couch_api_wrap:db_close(State#rep_state.source),
-    couch_api_wrap:db_close(State#rep_state.target).
+    stop_db_compaction_notifier(State#rep_state.target_db_compaction_notifier).
 
 
 do_last_checkpoint(#rep_state{seqs_in_progress = [],



Mime
View raw message