couchdb-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jch...@apache.org
Subject svn commit: r791136 - in /couchdb/trunk/src/couchdb: couch_btree.erl couch_key_tree.erl couch_view_updater.erl
Date Sat, 04 Jul 2009 15:17:45 GMT
Author: jchris
Date: Sat Jul  4 15:17:44 2009
New Revision: 791136

URL: http://svn.apache.org/viewvc?rev=791136&view=rev
Log:
last three dialyzer recommended cleanups

Modified:
    couchdb/trunk/src/couchdb/couch_btree.erl
    couchdb/trunk/src/couchdb/couch_key_tree.erl
    couchdb/trunk/src/couchdb/couch_view_updater.erl

Modified: couchdb/trunk/src/couchdb/couch_btree.erl
URL: http://svn.apache.org/viewvc/couchdb/trunk/src/couchdb/couch_btree.erl?rev=791136&r1=791135&r2=791136&view=diff
==============================================================================
--- couchdb/trunk/src/couchdb/couch_btree.erl (original)
+++ couchdb/trunk/src/couchdb/couch_btree.erl Sat Jul  4 15:17:44 2009
@@ -243,8 +243,9 @@
 % written. Plus with the "case size(term_to_binary(InList)) of" code it's
 % probably really inefficient.
 
-chunkify(_Bt, []) ->
-    [];
+% dialyzer says this pattern is never matched
+% chunkify(_Bt, []) ->
+%     [];
 chunkify(Bt, InList) ->
     case size(term_to_binary(InList)) of
     Size when Size > ?CHUNK_THRESHOLD ->

Modified: couchdb/trunk/src/couchdb/couch_key_tree.erl
URL: http://svn.apache.org/viewvc/couchdb/trunk/src/couchdb/couch_key_tree.erl?rev=791136&r1=791135&r2=791136&view=diff
==============================================================================
--- couchdb/trunk/src/couchdb/couch_key_tree.erl (original)
+++ couchdb/trunk/src/couchdb/couch_key_tree.erl Sat Jul  4 15:17:44 2009
@@ -191,7 +191,7 @@
         {LeafsFound ++ RestLeafsFound, KeysRemaining};
     KeysToGet2 ->
         LeafsFound = get_all_leafs_simple(Pos, [Tree], KeyPathAcc),
-        LeafKeysFound = [LeafKeyFound || {LeafKeyFound, _, _} <- LeafsFound],
+        LeafKeysFound = [LeafKeyFound || {LeafKeyFound, _} <- LeafsFound],
         KeysToGet2 = KeysToGet2 -- LeafKeysFound,
         {RestLeafsFound, KeysRemaining} = get_key_leafs_simple(Pos, RestTree, KeysToGet2,
KeyPathAcc),
         {LeafsFound ++ RestLeafsFound, KeysRemaining}

Modified: couchdb/trunk/src/couchdb/couch_view_updater.erl
URL: http://svn.apache.org/viewvc/couchdb/trunk/src/couchdb/couch_view_updater.erl?rev=791136&r1=791135&r2=791136&view=diff
==============================================================================
--- couchdb/trunk/src/couchdb/couch_view_updater.erl (original)
+++ couchdb/trunk/src/couchdb/couch_view_updater.erl Sat Jul  4 15:17:44 2009
@@ -123,7 +123,7 @@
             _ ->
                 exit(reset)
             end;
-        {not_found, deleted} ->
+        {not_found, missing} ->
             exit(reset)
         end;
     {false, <<?DESIGN_DOC_PREFIX, _/binary>>} -> % we skip design docs



Mime
View raw message