corinthia-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jan i <j...@apache.org>
Subject [RESULT][VOTE] incubator_corinthia_release_0.1
Date Fri, 28 Aug 2015 16:08:30 GMT
Hi

thanks for voting,

we have 3 +1 , 0 +0, 0 -1.

We will continue making the release artifacts.

rgds
jan i.

On 23 August 2015 at 13:43, Justin Mclean <justin@classsoftware.com> wrote:

> Hi,
>
> +1 binding
>
> I checked:
>  - signatures and hashes correct
>  - file names contain incubator rather than incubating - but intent is
> clear
>  - DISCLAIMER exits
>  - LICENSE and NOTICE correct
>  - All source files have Apache headers
>  - No unexpected binary files
>
> I wasn’t to able to compile from source as I don’t have the correct
> environment set up, but I could follow the build instructions.
>
> Please fix the release artefact name for the net release - incubating
> rather than incubator.
>
> Things you may want to think about changing of for the next release,
> however none are actually required.
>  - put the hashes in .md5 / .sha files rather than CHECKSUMS (tends to be
> the way it’s done)
>  - have the version number in the unzipped directory (incubator-corinthia)
>  - InfoPlist.strings has zero real content so an Apache header not needed
> but could be added for completeness
>  - Be nice to have the build instruction in the release and not referenced
> via a URL (as the URL and it’s contents may change)
>
> Thanks,
> Justin
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message