Return-Path: X-Original-To: apmail-corinthia-dev-archive@minotaur.apache.org Delivered-To: apmail-corinthia-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F18EE18B89 for ; Tue, 7 Jul 2015 19:14:03 +0000 (UTC) Received: (qmail 38337 invoked by uid 500); 7 Jul 2015 19:14:03 -0000 Delivered-To: apmail-corinthia-dev-archive@corinthia.apache.org Received: (qmail 38304 invoked by uid 500); 7 Jul 2015 19:14:03 -0000 Mailing-List: contact dev-help@corinthia.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@corinthia.incubator.apache.org Delivered-To: mailing list dev@corinthia.incubator.apache.org Received: (qmail 38293 invoked by uid 99); 7 Jul 2015 19:14:03 -0000 Received: from Unknown (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Jul 2015 19:14:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 6DA5CC068C for ; Tue, 7 Jul 2015 19:14:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.991 X-Spam-Level: *** X-Spam-Status: No, score=3.991 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=3, KAM_LAZY_DOMAIN_SECURITY=1, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id alAxzcdkWbzH for ; Tue, 7 Jul 2015 19:13:53 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with SMTP id 5969B24962 for ; Tue, 7 Jul 2015 19:13:53 +0000 (UTC) Received: (qmail 38241 invoked by uid 99); 7 Jul 2015 19:13:53 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Jul 2015 19:13:53 +0000 Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 9AB061A0155 for ; Tue, 7 Jul 2015 19:13:52 +0000 (UTC) Received: by wiga1 with SMTP id a1so265524069wig.0 for ; Tue, 07 Jul 2015 12:13:51 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.180.77.40 with SMTP id p8mr55348018wiw.29.1436296431164; Tue, 07 Jul 2015 12:13:51 -0700 (PDT) Received: by 10.28.6.131 with HTTP; Tue, 7 Jul 2015 12:13:51 -0700 (PDT) In-Reply-To: <4A17F2DB-8211-4F48-A1B8-118FF2845134@apache.org> References: <4A17F2DB-8211-4F48-A1B8-118FF2845134@apache.org> Date: Tue, 7 Jul 2015 21:13:51 +0200 Message-ID: Subject: Re: ODF Lenses From: jan i To: "dev@corinthia.incubator.apache.org" Content-Type: multipart/alternative; boundary=f46d0402abef92806e051a4dd237 --f46d0402abef92806e051a4dd237 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 6 July 2015 at 18:09, Peter Kelly wrote: > > On 6 Jul 2015, at 8:04 pm, Ian C wrote: > > > > Thanks for the feedback. > > > > Re warnings, I don't see any in the ODF code, I get a couple in minizip= . > > > > Am I missing some compiler/make switches I wonder. > > > > My compiler is gcc version 4.9.2 20150212 (Red Hat 4.9.2-6) (GCC) > > > > If I'd seen the warnings I would have addressed them. > > I=E2=80=99m using Xcode 6.4, which uses clang as its compiler: > > Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn) > Target: x86_64-apple-darwin14.4.0 > Thread model: posix > > I=E2=80=99m fortunate enough to have OS X, Ubuntu, and Window 7 accessibl= e to me > (the latter two under VMs) and always test new commits on all three > platforms before pushing, but I understand not everyone has such a setup = - > so don=E2=80=99t feel bad about missing warnings that don=E2=80=99t show = up on your system. > I=E2=80=99ll be happy to correct any problems I see as they arise if you = like. > > Jan: Do you know if it would be possible for us to get buildbots set up > for the three platforms? > it should be possible let me file a JIRA. OS X 10.x Ubuntu 12.x Window 7 (sure we should not go for 8?) rgds jan i. > > Here are the errors I get: > > DocFormats/filters/odf/src/ODF.c:30:19: Unused variable 'conv' > DocFormats/filters/odf/src/ODF.c:54:1: Control reaches end of non-void > function > DocFormats/filters/odf/src/ODF.c:59:1: Control reaches end of non-void > function > DocFormats/filters/odf/src/formatting/ODFStyles.c > DocFormats/filters/odf/src/formatting/ODFStyles.c:49:62: Data argument no= t > used by format string > DocFormats/filters/odf/src/formatting/ODFStyles.c:120:128: Data argument > not used by format string > DocFormats/filters/odf/src/formatting/ODFStyles.c:146:112: Data argument > not used by format string > DocFormats/filters/odf/src/formatting/ODFStyles.c:169:110: Data argument > not used by format string > DocFormats/filters/odf/src/text/ODFText.c > DocFormats/filters/odf/src/text/ODFText.c:157:1: Control reaches end of > non-void function > DocFormats/filters/odf/src/text/gbg_test.c > DocFormats/filters/odf/src/text/gbg_test.c:139:21: Unused variable 's' > DocFormats/filters/odf/src/text/gbg_test.c:318:51: Format specifies type > 'size_t' (aka 'unsigned long') but the argument has type 'Tag' (aka > 'unsigned int') > DocFormats/filters/odf/src/text/gbg_test.c:334:28: Unused variable > 'attrDecl' > DocFormats/filters/odf/src/text/gbg_test.c:346:54: Format specifies type > 'size_t' (aka 'unsigned long') but the argument has type 'Tag' (aka > 'unsigned int') > > =E2=80=94 > Dr Peter M. Kelly > pmkelly@apache.org > > PGP key: http://www.kellypmk.net/pgp-key > (fingerprint 5435 6718 59F0 DD1F BFA0 5E46 2523 BAA1 44AE 2966) > > --f46d0402abef92806e051a4dd237--