Return-Path: X-Original-To: apmail-corinthia-dev-archive@minotaur.apache.org Delivered-To: apmail-corinthia-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0FA8617364 for ; Tue, 17 Mar 2015 12:38:38 +0000 (UTC) Received: (qmail 78688 invoked by uid 500); 17 Mar 2015 12:38:37 -0000 Delivered-To: apmail-corinthia-dev-archive@corinthia.apache.org Received: (qmail 78658 invoked by uid 500); 17 Mar 2015 12:38:37 -0000 Mailing-List: contact dev-help@corinthia.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@corinthia.incubator.apache.org Delivered-To: mailing list dev@corinthia.incubator.apache.org Received: (qmail 78647 invoked by uid 99); 17 Mar 2015 12:38:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Mar 2015 12:38:37 +0000 X-ASF-Spam-Status: No, hits=-1997.8 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 17 Mar 2015 12:38:36 +0000 Received: (qmail 77488 invoked by uid 99); 17 Mar 2015 12:38:16 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Mar 2015 12:38:16 +0000 Received: from mail-lb0-f176.google.com (mail-lb0-f176.google.com [209.85.217.176]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 9FEDB1A02E4 for ; Tue, 17 Mar 2015 12:38:15 +0000 (UTC) Received: by lbcgn8 with SMTP id gn8so5865685lbc.2 for ; Tue, 17 Mar 2015 05:38:14 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.152.29.68 with SMTP id i4mr10029448lah.19.1426595894003; Tue, 17 Mar 2015 05:38:14 -0700 (PDT) Received: by 10.112.124.105 with HTTP; Tue, 17 Mar 2015 05:38:13 -0700 (PDT) In-Reply-To: References: <0000014c09c48e9f-af345524-63e8-45eb-ae67-dbdbad02e662-000000@email.amazonses.com> <522DE1E3-9D52-4418-B9D4-5F9125D8719E@apache.org> Date: Tue, 17 Mar 2015 13:38:13 +0100 Message-ID: Subject: Re: [dfwebserver] Python binding From: jan i To: "dev@corinthia.incubator.apache.org" Content-Type: multipart/alternative; boundary=089e0158c0a480122505117b3d8b X-Virus-Checked: Checked by ClamAV on apache.org --089e0158c0a480122505117b3d8b Content-Type: text/plain; charset=UTF-8 On 17 March 2015 at 12:52, Franz de Copenhague < franzdecopenhague@outlook.com> wrote: > > > ---------------------------------------- > > Date: Tue, 17 Mar 2015 12:15:34 +0100 > > Subject: Re: [dfwebserver] Python binding > > From: jani@apache.org > > To: dev@corinthia.incubator.apache.org > > > > On 17 March 2015 at 12:05, Franz de Copenhague < > > franzdecopenhague@outlook.com> wrote: > > > >> > >>> I think my technical comment might have got lost in translation :-) > >>> > >>> Could you please consider naming your bindings different, I actually > >>> thought you had copied the dfconvert code > >> > >> I think that using a similar name to the C API which is been binding to > >> python makes sense and it is how other bindings are done. So, a > developer > >> whom knows DocFormat C API would understand the python API at first > place. > >> > >>> I would suggest (but it is your choice) to put all bindings in 1 source > >>> file and name it e.g. docFormatPython.c > >> > >> The bindind is following the consumers C API pattern with 2 main.c files > >> for dfconvert and dfutil that generates 2 executables dfconvert and > dfutil. > >> For me, makes sense your suggestion if you have plans to refactory the > >> DocFormat C API and have only one main.c with dfconvert and dfutil > features > >> all together. > >> > > > > Please be aware dfconvert and dfutil are consumers the USE docFormat.lib > > they do not represent the docformats API. > > > > if you look inside dfconvert/dfutil they call functions inside docFormats > > (the library) that is part of the API. > > > > I think peter gave you a list of all the JS functions we have that calls > > back info the library (it is some 40+ calls) > > > > So seen from a release perspective our aim is to have > > > > docFormats library with a C-api > > dfconvert executable as a consumer of docFormats > > dftest executable as a consumer of docFormats > > dfWebServer executable as a consumer with python bindings fo docFormats > > > > So you can dfconvert, dftest and dfWebserver is parallel (dfutil is more > or > > less on its way out). > > > > I hope that explains why I suggested a name change. > > > > rgds > > jan I. > > > > Jan, is there any C consumer for the JS functions that you point out above? > No not currently the consumer "corinthia" (desktop editor) will use them all. > > Peter, > > Jan mentions this link > https://cwiki.apache.org/confluence/display/Corinthia/API+reference but I > am seeing a lot of functions required by the front-end aka Editor Library. > Would you split up in 2 list for front-end and back-end? Also, will be very > helpful to know what is the corresponding C API for each back-end > functionality. > We need them all, the frontend calls the backend which call the C API. Sadly enough docformat library does not yet have a formal C Api, but we call functions deep within. I am working on the desktop editor (right now stuck in some 64bit issues), and as I work through it, I will have the functions calling the corresponding docformats functions. I did not expect you to implement all these bindings, since they do not exist, but merely used it to explain why I feel you use wrong names for your current bindings. Let us first get that up and running you have, and hope that I in the meantime can provide a consumer that shows all the needed calls. rgds jan I. > > franz > > > --089e0158c0a480122505117b3d8b--