Mailing-List: contact dev-help@corinthia.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@corinthia.incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of kellypmk@gmail.com designates
 209.85.192.181 as permitted sender)
From: Peter Kelly <kellypmk@gmail.com>
Content-Type: multipart/alternative;
 boundary="Apple-Mail=_DF559973-EE69-4DB7-AB05-891CB82DCD7E"
Message-Id: <C4469EA7-00DF-4C69-8A42-B6729286BBAD@gmail.com>
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2090\))
Subject: Re: libxml2 and iconv question, do we really need iconv ?
Date: Mon, 23 Mar 2015 21:03:20 +0700
References: 
 <CAK2iWdTBsr47vTud4VvUo+ThiUuywK2TdHmEM5frxyPfUZUS7Q@mail.gmail.com>
To: dev@corinthia.incubator.apache.org
In-Reply-To: 
 <CAK2iWdTBsr47vTud4VvUo+ThiUuywK2TdHmEM5frxyPfUZUS7Q@mail.gmail.com>

--Apple-Mail=_DF559973-EE69-4DB7-AB05-891CB82DCD7E
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

I have about 70% of an XML parser done that I haven=E2=80=99t gotten =
around to finishing yet. Once that=E2=80=99s completed, we don=E2=80=99t =
need libxml. I can=E2=80=99t remember if we need iconv; it=E2=80=99s =
used for character set conversions but DocFormats is UTF-8 native (as is =
libxml), and support for UTF-16 would not be hard (if it=E2=80=99s even =
needed).

I would strongly argue against keeping sources of libraries in our =
repositories except in the case where we have made changes to those =
libraries. If we do that we have to include all of SDL_image and thus =
all of SDL, and that leads to quite a big repository. The same goes for =
libz etc. Most projects have lots and lots of dependencies and are =
handled just fine by standard package dependency systems e.g. apt-get.

Furthermore, we want to use the system libxml where available, both to =
take advantage of shared libraries (libxml only needs to exist in memory =
once, the OS maps it into the address space of each process that uses =
it), and for security updates (system libxml updated due to =
vulnerability, programs using DocFormats are still vulnerable until we =
go and update our own version).

--
Dr. Peter M. Kelly
kellypmk@gmail.com
http://www.kellypmk.net/

PGP key: http://www.kellypmk.net/pgp-key =
<http://www.kellypmk.net/pgp-key>
(fingerprint 5435 6718 59F0 DD1F BFA0 5E46 2523 BAA1 44AE 2966)

> On 23 Mar 2015, at 3:29 pm, jan i <jani@apache.org> wrote:
>=20
> Hi.
>=20
> I am nearly finished with the x64 port for windows, I have compiled =
all
> libraries we need.
>=20
> I wanted to see if we could keep the library sources in our Repo, and
> integrate them in our build
> system, as it would simplify things. Since I am biased I asked on
> general@i.a.o to get the opinion
> of outside Mentors. I got a few responses (strangely enough all in
> private), and it turns out many projects do as I suggest.
>=20
> However one of the others mentors found a license problem with iconv. =
We do
> not use iconv, but by default libxml2 does. I can configure libxml2 =
not to
> include iconv, but I wanted to ask in here, if we need the =
functionality ?
>=20
> If not my plan has changed a bit, and I will include the sources in
> platform, make a single commit with each original source, noting the =
URL
> and version in the commit text (and add it to LICENSE). Then I will =
add my
> changes, which will be solely CMAKE files NO source changes.
>=20
> Having the source in our build system, will also allow us to decide =
how to
> handle other platforms.
>=20
> Rgds
> jan I.


--Apple-Mail=_DF559973-EE69-4DB7-AB05-891CB82DCD7E--