corinthia-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Kelly (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COR-49) Part 2 of the x*alloc project.
Date Tue, 03 Mar 2015 14:53:06 GMT

    [ https://issues.apache.org/jira/browse/COR-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345166#comment-14345166
] 

Peter Kelly commented on COR-49:
--------------------------------

Hi Gabriela, this patch looks fine - you can go ahead and commit. I've confirmed it builds
& passed all tests on OS X, Windows, and Linux (including with valgrind on the latter).

Note the following guidelines on commit messages - http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html.
I'm not sure whether you've read this already or not, but your message complies with these
guidelines, so that's great to see! :)

> Part 2 of the x*alloc project. 
> -------------------------------
>
>                 Key: COR-49
>                 URL: https://issues.apache.org/jira/browse/COR-49
>             Project: Corinthia
>          Issue Type: Improvement
>          Components: DocFormats - API, DocFormats - core, DocFormats - filters, DocFormats
- ODF filter, DocFormats - OOXML filter, DocFormats - platform
>    Affects Versions: 0.5
>            Reporter: Gabriela Gibson
>            Priority: Minor
>         Attachments: malloc.logmesg, malloc.patch
>
>
>  1) changes to Wrapper.c
>  2) changing calloc to xcalloc
>  3) changing realloc to xrealloc
>  4) changing malloc to xmalloc



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message