corinthia-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jan iversen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COR-47) Add malloc and free wrapper.
Date Wed, 25 Feb 2015 19:13:04 GMT

    [ https://issues.apache.org/jira/browse/COR-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337004#comment-14337004
] 

jan iversen commented on COR-47:
--------------------------------

I am sorry, but I cannot apply this patch, for a couple of reasons:

- It does not implement xmalloc(), xfree() as agreed to
malloc(), realloc() and free() calls should be replaced in the code by xmalloc() ...
- It implements a function in Linux.c leaving Windows unaffected
It should be implemented in wrapper.c, which is for all platforms
- It changed the linker statement in CMakeList.txt
This is not needed, malloc() is linked to in the current master.

In general it seems you took a different approach that mailed on dev@. When changing your
intentions that much, we need to agree to it.

sorry, but I hope you are upto make the patch we agreed to on dev@ (as I summarized above).


> Add malloc and free wrapper.
> ----------------------------
>
>                 Key: COR-47
>                 URL: https://issues.apache.org/jira/browse/COR-47
>             Project: Corinthia
>          Issue Type: Improvement
>          Components: Build, DocFormats - platform
>    Affects Versions: 0.5
>            Reporter: Gabriela Gibson
>            Priority: Minor
>         Attachments: logmsg.txt, malloc.patch
>
>
> Added malloc wrapper function that affects the entire build.  See
> http://www.cs.cmu.edu/afs/cs/academic/class/15213-s03/src/interposition/mymalloc.c
> for some alternatives and the 'cooking recipe'.
> * CMakeLists.txt:
>   (): Add Major and Minor Version numbers, set to 0.5 to match JIRA
>     entry.
>   (Linux): Add new CMAKE_EXE_LINKER_FLAGS for Linker flags.  Currently
>     only affects the Linux build.
> * DocFormats/platform/src/Linux.c:
>     (): #include stdlib.h.
>     (__wrap_malloc): New function.  Ensure that a malloc failure exits
>       with error message.
>     (__wrap_free): New function. Ensure that ptr passed in is set to
>       NULL after free is applied.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message