Mailing-List: contact dev-help@corinthia.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@corinthia.incubator.apache.org
From: Peter Kelly <pmkelly@apache.org>
Content-Type: multipart/alternative;
 boundary="Apple-Mail=_631C06B3-00D7-4B61-A7B6-32483101D29D"
Message-Id: <C6F2825D-3B9B-4C98-BED4-B366E5D0226F@apache.org>
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2064\))
Subject: Re: svn commit: r1649986 - /incubator/corinthia/www/index.html
Date: Wed, 7 Jan 2015 19:54:23 +0700
References: <20150107022034.EEB6DAC003E@hades.apache.org>
 <CAK2iWdQQrzVU2ENKUw7qrhBheGb-xOByqsJ9qP5DSRX=gxtS+Q@mail.gmail.com>
 <54AD001B.6030703@apache.org>
To: dev@corinthia.incubator.apache.org
In-Reply-To: <54AD001B.6030703@apache.org>

--Apple-Mail=_631C06B3-00D7-4B61-A7B6-32483101D29D
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

I think that given the early state of the project website we should be =
focusing on the content and set of pages we present, not fiddling with =
layout. This is simply bikeshedding, which I=E2=80=99m seeing a lot more =
than I=E2=80=99d hoped for so far in the mailing lists.

How about we concentrate on important things like:

- Writing an ODF filter
- Instructions on how to build and work with the existing codebase =
(including coding style, workflow, and architecture discussion)
- A detailed set of goals we hope to achieve with the project (the =
proposal is a start, but nowhere near what we ultimately need)
- Based on the detailed set of goals, figure out what functionality we =
want to expose from the API

My vote is to to have Dorte take responsibility of the design aspects =
(it=E2=80=99s certainly not my area of expertise), and for us to =
concentrate on the content and mission of the project. Arguments over =
font sizes and line endings seem like the least important aspects of the =
project I could imagine.

=E2=80=94
Dr Peter M. Kelly
pmkelly@apache.org

PGP key: http://www.kellypmk.net/pgp-key =
<http://www.kellypmk.net/pgp-key>
(fingerprint 5435 6718 59F0 DD1F BFA0 5E46 2523 BAA1 44AE 2966)

> On 7 Jan 2015, at 7:15 pm, Andrea Pescetti <pescetti@apache.org> =
wrote:
>=20
> On 07/01/2015 jan i wrote:
>> Having now studied your patch, I have 3 questions:
>=20
> I suggest to set Reply-To for the commits list to dev and assume that =
people who subscribe to commits read dev and that all mails to commits =
are automatically originated.
>=20
>> - Is it on purpose you changed all lines in the file....that is kind =
of
>> very brutal.
>=20
> This is just due to broken line ending detection. =
http://svn.apache.org/viewvc/incubator/corinthia/www/index.html?r1=3D16498=
90&r2=3D1649986&pathrev=3D1649986&diff_format=3Dh shows it correctly, =
it's one line.
>=20
>> - Why only change one file, this effect is on all pages.
>=20
> This is correct, but maybe the problem is with repeating the same =
footer across all pages by copy-paste. Anyway yes, it's surely better to =
enforce consistency of the footer if we have no technology to include it =
automatically (but at the very least I expect that SSI is enabled).
>=20
>> - What is the urgency, that needed a "brute force fix" instead of =
doing it
>> correct
>=20
> Actually this is kind of the right way to do it. I mean:
> - Changing the Foundation files is a no-go. You want to be able to =
update to a newer version of the framework. So what Dennis thought to be =
the "right way" is not the right way at all: Foundation files are to be =
considered read-only.
> - Overriding default settings with a custom CSS file loaded after the =
default ones is what you should do and what I recommend as a good =
practice, even though I never played with Foundation.
> - Missing that, inline styles are an acceptable trade-off.
>=20
>> It breaks the responsive design.
>=20
> No it doesn't, since it does not make changes that are relevant for =
the box model. This is true of this particular case only, of course.
>=20
> By the way, I started fixing it yesterday but then saw Dorte's mail =
and stopped. Anyway, if you modify line 83 at the link above from
> <div class=3D"row">
> to
> <div class=3D"row columns">
> you solve the margin problem Dennis was unhappy with. But I didn't =
have time to check whether this is semantically the best solution.
>=20
> Regards,
>  Andrea.


--Apple-Mail=_631C06B3-00D7-4B61-A7B6-32483101D29D--