Return-Path: X-Original-To: apmail-corinthia-dev-archive@minotaur.apache.org Delivered-To: apmail-corinthia-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B2014C539 for ; Thu, 8 Jan 2015 16:15:57 +0000 (UTC) Received: (qmail 36039 invoked by uid 500); 8 Jan 2015 16:15:59 -0000 Delivered-To: apmail-corinthia-dev-archive@corinthia.apache.org Received: (qmail 36012 invoked by uid 500); 8 Jan 2015 16:15:59 -0000 Mailing-List: contact dev-help@corinthia.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@corinthia.incubator.apache.org Delivered-To: mailing list dev@corinthia.incubator.apache.org Received: (qmail 35862 invoked by uid 99); 8 Jan 2015 16:15:56 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Jan 2015 16:15:56 +0000 X-ASF-Spam-Status: No, hits=1.0 required=5.0 tests=SPF_SOFTFAIL X-Spam-Check-By: apache.org Received-SPF: softfail (nike.apache.org: transitioning domain of dennis.hamilton@acm.org does not designate 216.234.124.52 as permitted sender) Received: from [216.234.124.52] (HELO barracuda.supercp.com) (216.234.124.52) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Jan 2015 16:15:29 +0000 X-ASG-Debug-ID: 1420733712-089ef7341e1055810001-KCmPzH Received: from a2s42.a2hosting.com (a2s42.a2hosting.com [216.119.133.2]) by barracuda.supercp.com with ESMTP id vZebuHUeYK24pVjJ for ; Thu, 08 Jan 2015 11:15:12 -0500 (EST) X-Barracuda-Envelope-From: dennis.hamilton@acm.org X-Barracuda-Apparent-Source-IP: 216.119.133.2 Received: from 97-113-57-118.tukw.qwest.net ([97.113.57.118]:64890 helo=Astraendo2) by a2s42.a2hosting.com with esmtpa (Exim 4.82) (envelope-from ) id 1Y9Fjq-002N8g-Nc for dev@corinthia.incubator.apache.org; Thu, 08 Jan 2015 11:15:11 -0500 Reply-To: From: "Dennis E. Hamilton" To: Subject: Test Documents (was RE: Coding Standards page) Date: Thu, 8 Jan 2015 08:15:07 -0800 X-ASG-Orig-Subj: Test Documents (was RE: Coding Standards page) Organization: NuovoDoc Message-ID: <009201d02b5e$47fdf410$d7f9dc30$@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 15.0 Thread-Index: AdArWaGLOFoO0ec1QViTLqADp/Yrgw== Content-Language: en-us X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - a2s42.a2hosting.com X-AntiAbuse: Original Domain - corinthia.incubator.apache.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - acm.org X-Get-Message-Sender-Via: a2s42.a2hosting.com: authenticated_id: himself+orcmid.com/only user confirmed/virtual account not confirmed X-Barracuda-Connect: a2s42.a2hosting.com[216.119.133.2] X-Barracuda-Start-Time: 1420733712 X-Barracuda-URL: http://barracuda.supercp.com:8000/cgi-mod/mark.cgi Received-SPF: softfail (supercp.com: domain of transitioning dennis.hamilton@acm.org does not designate 97.113.57.118 as permitted sender) X-Virus-Scanned: by bsmtpd at supercp.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using per-user scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=4.0 KILL_LEVEL=5.0 tests=BSF_SPF_SOFTFAIL X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.14085 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 BSF_SPF_SOFTFAIL Custom Rule SPF Softfail X-Virus-Checked: Checked by ClamAV on apache.org -- replying below to -- From: jan i [mailto:jani@apache.org] Sent: Thursday, January 8, 2015 03:11 To: dev@corinthia.incubator.apache.org; Dennis Hamilton Subject: Re: Coding Standards page On 8 January 2015 at 00:40, Dennis E. Hamilton wrote: [ ... ] > It is OK to have binaries for test. Can you please add the right git > attributes to the main test dir. > > > I don't see a main test dir anywhere. > If you know of specific file extensions for binary content that we have, > please update the .gitattributes file at the repository root. I > couldn't > Find anything with a quick scan of the repository. > (The SVN definitions are different and we don't use our SVN that way.) > > When I went looking for a test directory, I found Peter's test documents. As well as I could determine, they are all .html files, so there is nothing to do. Looking at the poi files, I see that there are many in binary formats. I could simply add those to the list of binaries in .gitattributes. It would be better to have some sort of files to confirm that the .gitattributes is working, like a specimen of each file extension. I can make the .gitattributes changes. It will need to be reviewed > > My bad, I have one in my branch but it is not in the repo....I think went away because peter moved test cases into docFormats, since they were all white box testing. We need a test dir at top level for black box tests, please create one. May I suggest we add the poi test documents in a subdir, with a readme file that informs the origin. Dave@ thanks for your idea, and for sharing your concern...I think it is better to have them in our git repo, so developers dont need multiple version control clients. I am not taking an action on creation of a test directory. There is Need for more conversation on organization and whether to fork or to fetch, etc., to be considered. Also, there is no discussion yet of how tests themselves are conducted using whatever test documents there are. rgds jan i > [ ... ] > >