corinthia-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter Kelly (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COR-28) dfutil -zip produces invalid timestamps
Date Sun, 11 Jan 2015 03:44:34 GMT

    [ https://issues.apache.org/jira/browse/COR-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272793#comment-14272793
] 

Peter Kelly commented on COR-28:
--------------------------------

Actually I think this might be a bug in our code - the zipOpenNewFileInZip function in minizip
takes a fileinfo struct, and one of the fields of that is dosDate.

The comment in minizip's zip.h says that "if dos_date == 0, tmu_date is used". So we're supplying
as dos_date as 0 which should be fine according to this comment, though I'm not sure what
tmu_date is.

At any rate, I would recommend this be addressed as part of the proposed minizip replacement.

> dfutil -zip produces invalid timestamps
> ---------------------------------------
>
>                 Key: COR-28
>                 URL: https://issues.apache.org/jira/browse/COR-28
>             Project: Corinthia
>          Issue Type: Bug
>         Environment: Windows
>            Reporter: Dennis E. Hamilton
>            Priority: Minor
>         Attachments: dfutil-2015-01-10-1811-altZipFolder.png, dfutil-2015-01-10-1818-altWinZipView.png,
dfutil-2015-01-10-1821-7ZipTest.png
>
>
> The dfutil -zip function produces a Zip that fails to pass the WinZip test.
> The directory of files produced on behalf of COR-27 was zipped using dfutil -zip with
result zlib128-alt.zip.  .
> When viewed as a folder on Windows, no "Date modified" entries appear.
>  When viewed in WInZip the timestamps shown are the current time (changing each time
WinZip opens the archive).
> When the archive is tested, 7-zip shows no "Modified" timestamps and declares that there
are no errors in the Zip.
> When the archive is tested with WinZIp, there is an error report for every central directory
and local directory timestamp.  Here are the first few and last error messages (and note that
there are no separate folder entries in the produced zip):
> Warnings were issued - see below for details
> Testing ...
> For file "DLL_FAQ.txt", the time stamp in the central directory is invalid, using the
current system time instead.
> For file "include\zconf.h", the time stamp in the central directory is invalid, using
the current system time instead.
> For file "include\zlib.h", the time stamp in the central directory is invalid, using
the current system time instead.
> For file "lib\zdll.lib", the time stamp in the central directory is invalid, using the
current system time instead.
> For file "lib\zlib.def", the time stamp in the central directory is invalid, using the
current system time instead.
> For file "README.txt", the time stamp in the central directory is invalid, using the
current system time instead.
> [ ... ]
> For file "DLL_FAQ.txt", the time stamp in the local directory is invalid, using the current
system time instead.
> testing: DLL_FAQ.txt              OK
> For file "include\zconf.h", the time stamp in the local directory is invalid, using the
current system time instead.
> testing: include\zconf.h          OK
> For file "include\zlib.h", the time stamp in the local directory is invalid, using the
current system time instead.
> testing: include\zlib.h           OK
> For file "lib\zdll.lib", the time stamp in the local directory is invalid, using the
current system time instead.
> testing: lib\zdll.lib             OK
> For file "lib\zlib.def", the time stamp in the local directory is invalid, using the
current system time instead.
> testing: lib\zlib.def             OK
> For file "README.txt", the time stamp in the local directory is invalid, using the current
system time instead.
> testing: README.txt               OK
> [ ... ]
> At least one warning-error was detected in D:\Apache\corinthia\git\build-win32-x86\build\bin\zlib128-alt.zip.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message