corinthia-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jan i <j...@apache.org>
Subject Re: svn commit: r1649986 - /incubator/corinthia/www/index.html
Date Wed, 07 Jan 2015 09:06:29 GMT
On Wednesday, January 7, 2015, <orcmid@apache.org> wrote:

> Author: orcmid
> Date: Wed Jan  7 02:20:29 2015
> New Revision: 1649986
>
> URL: http://svn.apache.org/r1649986
> Log:
> BRUTE-FORCE FIX: The excessive leading in the small text of the Apache
> Incubator notice is hacked to <p style="line-height: 66%"> directly.  I was
> unable to crack the code on foundation.js and foundation.css so I made this
> direct style.


In my opinion this fix is no good.

It breaks the responsive design. If you want something different than
"small" then you should inherit that css style, so we dont loose all the
other properties.

I suggest to revert this patch.


jan i

>
> Modified:
>     incubator/corinthia/www/index.html
>
> Modified: incubator/corinthia/www/index.html
> URL:
> http://svn.apache.org/viewvc/incubator/corinthia/www/index.html?rev=1649986&r1=1649985&r2=1649986&view=diff
>
> ==============================================================================
> --- incubator/corinthia/www/index.html (original)
> +++ incubator/corinthia/www/index.html Wed Jan  7 02:20:29 2015
> @@ -9,89 +9,89 @@
>    </head>
>    <body>
>    <div class="fixed">
> -  <nav class="top-bar" data-topbar role="navigation">
> -  <ul class="title-area"> <li class="name"> <h1><a href="#"></a></h1>
> </li>
> -  <!-- Remove the class "menu-icon" to get rid of menu icon. Take out
> "Menu" to just have icon alone -->
> -  <li class="toggle-topbar menu-icon"><a
> href="#"><span>Menu</span></a></li> </ul>
> -  <section class="top-bar-section">
> -  <!-- Right Nav Section -->
> -          <ul class="right">
> -                  <li class="has-dropdown"><a href="#">Community</a>
> -                          <ul class="dropdown">
> -                                  <li><a
> href="contribute_community.html">Community</a></li>
> -                                  <li><a href="contribute_howto.html">How
> to contribute</a></li>
> -                                  <li><a
> href="contribute_committer.html">Committers</a></li>
> -                          </ul>
> -                       </li>
> -                  <li class="has-dropdown"><a href="#">Polices</a>
> -                          <ul class="dropdown">
> -                                  <li><a href="policy_coding.html">Coding
> standard</a></li>
> -                                  <li><a href="policy_git.html">Git
> usage</a></li>
> -                          </ul>
> -                       </li>
> -                  <li class="has-dropdown"><a href="#">Guides</a>
> -                          <ul class="dropdown">
> -                                  <li><a href="
> https://cwiki.apache.org/confluence/display/Corinthia/Git+FAQ"
> target="_blank">Git FAQ</a></li>
> -                                  <li><a href="
> https://cwiki.apache.org/confluence/display/Corinthia/Test+FAQ"
> target="_blank">Test FAQ</a></li>
> -                                  <li><a href="
> https://cwiki.apache.org/confluence/display/Corinthia/Build+FAQ"
> target="_blank">Build FAQ</a></li>
> -                          </ul>
> -                       </li>
> -                       <li class="has-dropdown"><a
> href="#">Documentation</a>
> -                               <ul class="dropdown">
> -                                   <li><a href="
> https://cwiki.apache.org/confluence/display/Corinthia">Wiki</a></li>
> -                                  <li><a href="
> https://cwiki.apache.org/confluence/display/Corinthia/Roadmap"
> target="_blank">Roadmap</a></li>
> -                                  <li><a
> href="learnmore.html">Background</a></li>
> -                               </ul>
> -                       </li>
> -               </ul>
> -         </div>
> -         <!--content section -->
> +  <nav class="top-bar" data-topbar role="navigation">
> +  <ul class="title-area"> <li class="name"> <h1><a href="#"></a></h1>
> </li>
> +  <!-- Remove the class "menu-icon" to get rid of menu icon. Take out
> "Menu" to just have icon alone -->
> +  <li class="toggle-topbar menu-icon"><a
> href="#"><span>Menu</span></a></li> </ul>
> +  <section class="top-bar-section">
> +  <!-- Right Nav Section -->
> +       <ul class="right">
> +           <li class="has-dropdown"><a href="#">Community</a>
> +               <ul class="dropdown">
> +                   <li><a
> href="contribute_community.html">Community</a></li>
> +                   <li><a href="contribute_howto.html">How to
> contribute</a></li>
> +                   <li><a
> href="contribute_committer.html">Committers</a></li>
> +               </ul>
> +            </li>
> +           <li class="has-dropdown"><a href="#">Polices</a>
> +               <ul class="dropdown">
> +                   <li><a href="policy_coding.html">Coding
> standard</a></li>
> +                   <li><a href="policy_git.html">Git usage</a></li>
> +               </ul>
> +            </li>
> +           <li class="has-dropdown"><a href="#">Guides</a>
> +               <ul class="dropdown">
> +                   <li><a href="
> https://cwiki.apache.org/confluence/display/Corinthia/Git+FAQ"
> target="_blank">Git FAQ</a></li>
> +                   <li><a href="
> https://cwiki.apache.org/confluence/display/Corinthia/Test+FAQ"
> target="_blank">Test FAQ</a></li>
> +                   <li><a href="
> https://cwiki.apache.org/confluence/display/Corinthia/Build+FAQ"
> target="_blank">Build FAQ</a></li>
> +               </ul>
> +            </li>
> +            <li class="has-dropdown"><a href="#">Documentation</a>
> +                <ul class="dropdown">
> +                        <li><a href="
> https://cwiki.apache.org/confluence/display/Corinthia">Wiki</a></li>
> +                   <li><a href="
> https://cwiki.apache.org/confluence/display/Corinthia/Roadmap"
> target="_blank">Roadmap</a></li>
> +                   <li><a href="learnmore.html">Background</a></li>
> +                </ul>
> +            </li>
> +        </ul>
> +      </div>
> +      <!--content section -->
>      <div class="row">
>        <div class="large-12 columns">
> -         <div class="panel">
> -         <img src="img/webbanner.jpg" width="1800" height="790" alt=""
> title="" />
> -               <h3>
> -               <br>Two-way file format conversion library and responsive
> design editor</h3>
> -               <p>with editing functionality on web, mobile platforms and
> desktops for people who work with multiple document formats, or just need a
> simple editor with full document support.</p>
> -               <h3>Want to join</h3>
> -               <p>We have work to do and welcome developers, testers and
> documenters to join our community. Initial tasks are
> -       to clean up granted code to make it easy to add filters (format
> converters), complete the ODF filter, work on editor
> -               and write tests and compliance sheets for supported file
> formats.</p>
> -               <p>We are very openminded, new ideas are welcome. The
> known desktop editors all have years of history in the code, we have
> started on a fresh, allowing experiments and thinking out of the box. If
> you have opinions you will feel welcome in our little community.</p>
> -
> -               <div class="row">
> -               <div class="large-6 medium-6 columns">
> -               <h3>Where to find us:</h3>
> -               <ul>
> -                       <li><a href="
> https://www.facebook.com/CorinthiaProject">Facebook page</a></li>
> -                       <li><a href="
> https://github.com/apache/incubator-corinthia">Github</a></li>
> -                       <li><a href="mailto:
> dev@corinthia.incubator.apache.org <javascript:;>">Send mail to Dev@
> </a></li>
> -                       <li><a href="
> http://www.mail-archive.com/dev@corinthia.incubator.apache.org">Dev@ mail
> list archive</a></li>
> -                       <li><a href="
> https://issues.apache.org/jira/browse/COR">Issues</a></li>
> -                       <li><a href="
> https://cwiki.apache.org/confluence/display/Corinthia">Wiki</a></li>
> -                       <li><a href="http://www.apache.org
> ">Apache.org</a></li>
> -               </ul>
> -           </div>
> -               <div class="large-6 medium-6 columns">
> -           <a class="twitter-timeline" data-dnt="true" href="
> https://twitter.com/ApacheCorinthia"
> -               data-widget-id="545906451257245696">Tweets by
> @ApacheCorinthia</a><script>!function(d,s,id){var
> js,fjs=d.getElementsByTagName(s)[0],p=/^http:/.test(d.location)?'http':'https';if(!d.getElementById(id)){js=d.createElement(s);
> js.id=id;js.src=p+"://platform.twitter.com/widgets.js
> ";fjs.parentNode.insertBefore(js,fjs);}}(document,"script","twitter-wjs");</script>
> -               </div>
> -               </div>
> +      <div class="panel">
> +      <img src="img/webbanner.jpg" width="1800" height="790" alt=""
> title="" />
> +        <h3>
> +        <br>Two-way file format conversion library and responsive design
> editor</h3>
> +        <p>with editing functionality on web, mobile platforms and
> desktops for people who work with multiple document formats, or just need a
> simple editor with full document support.</p>
> +        <h3>Want to join</h3>
> +        <p>We have work to do and welcome developers, testers and
> documenters to join our community. Initial tasks are
> +        to clean up granted code to make it easy to add filters (format
> converters), complete the ODF filter, work on editor
> +        and write tests and compliance sheets for supported file
> formats.</p>
> +        <p>We are very openminded, new ideas are welcome. The known
> desktop editors all have years of history in the code, we have started on a
> fresh, allowing experiments and thinking out of the box. If you have
> opinions you will feel welcome in our little community.</p>
> +
> +        <div class="row">
> +        <div class="large-6 medium-6 columns">
> +        <h3>Where to find us:</h3>
> +        <ul>
> +            <li><a href="https://www.facebook.com/CorinthiaProject">Facebook
> page</a></li>
> +            <li><a href="https://github.com/apache/incubator-corinthia
> ">Github</a></li>
> +            <li><a href="mailto:dev@corinthia.incubator.apache.org
> <javascript:;>">Send mail to Dev@</a></li>
> +            <li><a href="
> http://www.mail-archive.com/dev@corinthia.incubator.apache.org">Dev@ mail
> list archive</a></li>
> +            <li><a href="https://issues.apache.org/jira/browse/COR
> ">Issues</a></li>
> +            <li><a href="
> https://cwiki.apache.org/confluence/display/Corinthia">Wiki</a></li>
> +            <li><a href="http://www.apache.org">Apache.org</a></li>
> +        </ul>
> +        </div>
> +        <div class="large-6 medium-6 columns">
> +        <a class="twitter-timeline" data-dnt="true" href="
> https://twitter.com/ApacheCorinthia"
> +        data-widget-id="545906451257245696">Tweets by
> @ApacheCorinthia</a><script>!function(d,s,id){var
> js,fjs=d.getElementsByTagName(s)[0],p=/^http:/.test(d.location)?'http':'https';if(!d.getElementById(id)){js=d.createElement(s);
> js.id=id;js.src=p+"://platform.twitter.com/widgets.js
> ";fjs.parentNode.insertBefore(js,fjs);}}(document,"script","twitter-wjs");</script>
> +        </div>
> +        </div>
> +      </div>
> +    </div>
> +    <!-- footer section -->
> +    <div class="row">
> +      <div class="large-3 medium-3 columns"><a href="
> http://incubator.apache.org"><img src="img/incubatorlogo.png" width="229"
> height="57" alt=""
> +      title="apache incubator logo" /></a></div>
> +      <div class="large-9 medium-9 columns"><p style="line-height:
> 66%"><small>Apache Corinthia is an effort undergoing incubation at The
> Apache Software Foundation (ASF), sponsored
> +            by the Apache Incubator. Incubation is required of all newly
> accepted projects until a further review indicates
> +            that the infrastructure, communications, and decision making
> process have stabilized in a manner consistent with
> +            other successful ASF projects. While incubation status is not
> necessarily a reflection of the completeness or
> +            stability of the code, it does indicate that the project has
> yet to be fully endorsed by the ASF.
> +            Apache Corinthia is distributed under the Apache License
> v2.0.</small></p>
>        </div>
> -    </div>
> -       <!-- footer section -->
> -    <div class="row">
> -         <div class="large-3 medium-3 columns"><a href="
> http://incubator.apache.org"><img src="img/incubatorlogo.png" width="229"
> height="57" alt=""
> -         title="apache incubator logo" /></a></div>
> -         <div class="large-9 medium-9 columns"><p><small>Apache Corinthia
> is an effort undergoing incubation at The Apache Software Foundation (ASF),
> sponsored
> -                       by the Apache Incubator. Incubation is required of
> all newly accepted projects until a further review indicates
> -                       that the infrastructure, communications, and
> decision making process have stabilized in a manner consistent with
> -                       other successful ASF projects. While incubation
> status is not necessarily a reflection of the completeness or
> -                       stability of the code, it does indicate that the
> project has yet to be fully endorsed by the ASF.
> -                       Apache Corinthia is distributed under the Apache
> License v2.0.</small></p>
> -         </div>
> -       </div>
> -
> +    </div>
> +
>      <script src="js/vendor/jquery.js"></script>
>      <script src="js/foundation.min.js"></script>
>      <script>
>
>
>

-- 
Sent from My iPad, sorry for any misspellings.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message