Return-Path: X-Original-To: apmail-corinthia-commits-archive@minotaur.apache.org Delivered-To: apmail-corinthia-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2092617406 for ; Tue, 7 Apr 2015 16:19:34 +0000 (UTC) Received: (qmail 67759 invoked by uid 500); 7 Apr 2015 16:19:34 -0000 Delivered-To: apmail-corinthia-commits-archive@corinthia.apache.org Received: (qmail 67739 invoked by uid 500); 7 Apr 2015 16:19:34 -0000 Mailing-List: contact commits-help@corinthia.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@corinthia.incubator.apache.org Delivered-To: mailing list commits@corinthia.incubator.apache.org Received: (qmail 67719 invoked by uid 99); 7 Apr 2015 16:19:33 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Apr 2015 16:19:33 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of gabriela.gibson@gmail.com designates 209.85.223.175 as permitted sender) Received: from [209.85.223.175] (HELO mail-ie0-f175.google.com) (209.85.223.175) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Apr 2015 16:19:28 +0000 Received: by iebrs15 with SMTP id rs15so51389637ieb.3; Tue, 07 Apr 2015 09:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=BmQjS15M9xZN1p+O0sX1Tzh0Kkvrw+I8N4RepSKXuRU=; b=gR70TnOlubQoDQZUA785XW2MhWQbtLugAcxGRbHESc2OfvApyHYWnrpOAGLuC1b66+ p8QNY04lYJT867QWDQjwoGEpuZrBjNWa4UCNkXz+DGjrBYSP9fxr6gYgLjAR8+K2Dj+N KAdV4CyBerWqk4mNA71iULWyp8ePcJHKi/aNBGW15n3bZPJUmPctajACO5BeGFrPl6WR 7FmioKbUb422GN9jbnd8kUIDnMD8hYpMdHvY4acObzZw5w4DR6m1ED+UNGY34N8Hi0bu wRGUAo6vlc4OeVXownS3twtJ4urAYC1rlB38NELVEIkfbpPduPiXOHWZOjrvcCWrCMA9 vBXA== X-Received: by 10.43.24.76 with SMTP id rd12mr19340056icb.84.1428423503597; Tue, 07 Apr 2015 09:18:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.29.14 with HTTP; Tue, 7 Apr 2015 09:18:03 -0700 (PDT) In-Reply-To: References: <0ad6b6de54ed47a997a94e33c5aa6055@git.apache.org> From: Gabriela Gibson Date: Tue, 7 Apr 2015 17:18:03 +0100 Message-ID: Subject: Re: incubator-corinthia git commit: Remove duplicate DFPlatform.h include. To: dev@corinthia.incubator.apache.org Cc: commits@corinthia.incubator.apache.org Content-Type: multipart/alternative; boundary=bcaec51dd02d85558d051324c318 X-Virus-Checked: Checked by ClamAV on apache.org --bcaec51dd02d85558d051324c318 Content-Type: text/plain; charset=UTF-8 On Tue, Apr 7, 2015 at 3:21 PM, jan i wrote: > Hi. > > Just had a look at your commits (to be correct, looked at the test case > change, when this one arrived), they are 100% correct, please keep up the > good work. > > core and platform are in production so of course a bit more sensitive to > changes. The odf filter its not yet > production, so fell free to commit mini-changes as you feel they are ready. > > Ok ;-) Just to dip my toes in(gingerly), I added a little stub to dfutil -pp. Gotta start somewhere! G > rgds > jan i. > > > > > On 7 April 2015 at 16:08, wrote: > > > Repository: incubator-corinthia > > Updated Branches: > > refs/heads/master 7799c53ab -> ebd3c933f > > > > > > Remove duplicate DFPlatform.h include. > > > > * DocFormats/core/src/lib/DFFilesystem.c > > Remove duplicate DFPlatform.h include. > > > > > > Project: http://git-wip-us.apache.org/repos/asf/incubator-corinthia/repo > > Commit: > > > http://git-wip-us.apache.org/repos/asf/incubator-corinthia/commit/ebd3c933 > > Tree: > > http://git-wip-us.apache.org/repos/asf/incubator-corinthia/tree/ebd3c933 > > Diff: > > http://git-wip-us.apache.org/repos/asf/incubator-corinthia/diff/ebd3c933 > > > > Branch: refs/heads/master > > Commit: ebd3c933f4865133250e834c5f96b18a43fe6846 > > Parents: 7799c53 > > Author: Gabriela Gibson > > Authored: Tue Apr 7 15:08:02 2015 +0100 > > Committer: Gabriela Gibson > > Committed: Tue Apr 7 15:08:02 2015 +0100 > > > > ---------------------------------------------------------------------- > > DocFormats/core/src/lib/DFFilesystem.c | 1 - > > 1 file changed, 1 deletion(-) > > ---------------------------------------------------------------------- > > > > > > > > > http://git-wip-us.apache.org/repos/asf/incubator-corinthia/blob/ebd3c933/DocFormats/core/src/lib/DFFilesystem.c > > ---------------------------------------------------------------------- > > diff --git a/DocFormats/core/src/lib/DFFilesystem.c > > b/DocFormats/core/src/lib/DFFilesystem.c > > index 358b70e..6c1a1bc 100644 > > --- a/DocFormats/core/src/lib/DFFilesystem.c > > +++ b/DocFormats/core/src/lib/DFFilesystem.c > > @@ -22,7 +22,6 @@ > > #include "DFBuffer.h" > > #include > > #include "DFCharacterSet.h" > > -#include "DFPlatform.h" > > #include "DFCommon.h" > > #include > > #include > > > > > -- Visit my Coding Diary: http://gabriela-gibson.blogspot.com/ --bcaec51dd02d85558d051324c318 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On T= ue, Apr 7, 2015 at 3:21 PM, jan i <jani@apache.org> wrote:
=
Hi.

Just had a look at your commits (to be correct, looked at the test case
change, when this one arrived), they are 100% correct, please keep up the good work.

core and platform are in production so of course a bit more sensitive to changes. The odf filter its not yet
production, so fell free to commit mini-changes as you feel they are ready.=

Ok ;-)

Just to dip my toes i= n(gingerly), I added a little stub to dfutil -pp. =C2=A0

Gotta start somewhere!

G=C2=A0
rgds
jan i.




On 7 April 2015 at 16:08, <gbg@apache.= org> wrote:

> Repository: incubator-corinthia
> Updated Branches:
>=C2=A0 =C2=A0refs/heads/master 7799c53ab -> ebd3c933f
>
>
> Remove duplicate DFPlatform.h include.
>
> * DocFormats/core/src/lib/DFFilesystem.c
>=C2=A0 =C2=A0 =C2=A0Remove duplicate DFPlatform.h include.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/inc= ubator-corinthia/repo
> Commit:
> http://git-wip-us.apache.org/repos/asf/i= ncubator-corinthia/commit/ebd3c933
> Tree:
> http://git-wip-us.apache.org/repos/asf/inc= ubator-corinthia/tree/ebd3c933
> Diff:
> http://git-wip-us.apache.org/repos/asf/inc= ubator-corinthia/diff/ebd3c933
>
> Branch: refs/heads/master
> Commit: ebd3c933f4865133250e834c5f96b18a43fe6846
> Parents: 7799c53
> Author: Gabriela Gibson <gbg@apac= he.org>
> Authored: Tue Apr 7 15:08:02 2015 +0100
> Committer: Gabriela Gibson <gbg@a= pache.org>
> Committed: Tue Apr 7 15:08:02 2015 +0100
>
> ----------------------------------------------------------------------=
>=C2=A0 DocFormats/core/src/lib/DFFilesystem.c | 1 -
>=C2=A0 1 file changed, 1 deletion(-)
> ----------------------------------------------------------------------=
>
>
>
> htt= p://git-wip-us.apache.org/repos/asf/incubator-corinthia/blob/ebd3c933/DocFo= rmats/core/src/lib/DFFilesystem.c
> ----------------------------------------------------------------------=
> diff --git a/DocFormats/core/src/lib/DFFilesystem.c
> b/DocFormats/core/src/lib/DFFilesystem.c
> index 358b70e..6c1a1bc 100644
> --- a/DocFormats/core/src/lib/DFFilesystem.c
> +++ b/DocFormats/core/src/lib/DFFilesystem.c
> @@ -22,7 +22,6 @@
>=C2=A0 #include "DFBuffer.h"
>=C2=A0 #include <DocFormats/DFError.h>
>=C2=A0 #include "DFCharacterSet.h"
> -#include "DFPlatform.h"
>=C2=A0 #include "DFCommon.h"
>=C2=A0 #include <assert.h>
>=C2=A0 #include <errno.h>
>
>



--
--bcaec51dd02d85558d051324c318--