corinthia-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmke...@apache.org
Subject [2/6] incubator-corinthia git commit: Remove NamesTests.c to fix compilation on windows
Date Tue, 30 Dec 2014 14:43:48 GMT
Remove NamesTests.c to fix compilation on windows

The names directory contains only constants for representing particular
element names, and doesn't need tests. Removing NamesTests.c for the
time being as it inadvertently re-defined the LibTests symbol, which
caused compilation to fail on windows.

The way we use integer values to identify elements in the DOM tree needs
to be re-thought anyway, as it doesn't scale or separate for different
file formats. For example there's no situation in which you would have
ODF and OOXML elements in the same XML document; there needs to be a
separate "namespace", to to speak, of integer tags for each filter, with
common ones like HTML included.


Project: http://git-wip-us.apache.org/repos/asf/incubator-corinthia/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-corinthia/commit/88d4ac35
Tree: http://git-wip-us.apache.org/repos/asf/incubator-corinthia/tree/88d4ac35
Diff: http://git-wip-us.apache.org/repos/asf/incubator-corinthia/diff/88d4ac35

Branch: refs/heads/master
Commit: 88d4ac353cfdbed76351d9f825c8f1b6d8769c8d
Parents: a3e5d61
Author: Peter Kelly <peter@uxproductivity.com>
Authored: Tue Dec 30 20:48:24 2014 +0700
Committer: Peter Kelly <peter@uxproductivity.com>
Committed: Tue Dec 30 20:50:45 2014 +0700

----------------------------------------------------------------------
 DocFormats/core/CMakeLists.txt           |  5 -----
 DocFormats/core/tests/names/NamesTests.c | 27 ---------------------------
 2 files changed, 32 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-corinthia/blob/88d4ac35/DocFormats/core/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/DocFormats/core/CMakeLists.txt b/DocFormats/core/CMakeLists.txt
index 927dff0..cfd46cc 100644
--- a/DocFormats/core/CMakeLists.txt
+++ b/DocFormats/core/CMakeLists.txt
@@ -120,9 +120,6 @@ set(GroupSrcNames
     src/names/DFXMLNamespaces.c
     src/names/DFXMLNamespaces.h)
 
-set(GroupTestsNames
-    tests/names/NamesTests.c)
-
 
 
 ###
@@ -182,7 +179,6 @@ add_library(core OBJECT
     ${GroupTestsCSS}
     ${GroupTestsHTML}
     ${GroupTestsLib}
-    ${GroupTestsNames}
     ${GroupTestsXML})
 
 source_group(src\\common   FILES ${GroupSrcCommon})
@@ -195,6 +191,5 @@ source_group(tests\\common FILES ${GroupTestsCommon})
 source_group(tests\\css    FILES ${GroupTestsCSS})
 source_group(tests\\html   FILES ${GroupTestsHTML})
 source_group(tests\\lib    FILES ${GroupTestsLib})
-source_group(tests\\names  FILES ${GroupTestsNames})
 source_group(tests\\xml    FILES ${GroupTestsXML})
 set_property(TARGET core PROPERTY FOLDER DocFormats)

http://git-wip-us.apache.org/repos/asf/incubator-corinthia/blob/88d4ac35/DocFormats/core/tests/names/NamesTests.c
----------------------------------------------------------------------
diff --git a/DocFormats/core/tests/names/NamesTests.c b/DocFormats/core/tests/names/NamesTests.c
deleted file mode 100644
index cbf3bc7..0000000
--- a/DocFormats/core/tests/names/NamesTests.c
+++ /dev/null
@@ -1,27 +0,0 @@
-// Copyright 2012-2014 UX Productivity Pty Ltd
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-#include "DFUnitTest.h"
-#include <stddef.h>
-
-static void test_sample(void)
-{
-}
-
-TestGroup LibTests = {
-    "core.lib", {
-        { "sample", PlainTest, test_sample },
-        { NULL, PlainTest, NULL }
-    }
-};


Mime
View raw message