From issues-return-103644-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Tue Sep 1 15:57:41 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id D0F73180660 for ; Tue, 1 Sep 2020 17:57:41 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 08255123A7B for ; Tue, 1 Sep 2020 15:57:41 +0000 (UTC) Received: (qmail 93403 invoked by uid 500); 1 Sep 2020 15:57:40 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 93379 invoked by uid 99); 1 Sep 2020 15:57:40 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2020 15:57:40 +0000 From: =?utf-8?q?GitBox?= To: issues@cordova.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bcordova-plugin-inappbrowser=5D_dpa99c_commented_on?= =?utf-8?q?_pull_request_=23700=3A_Android_-_Changed_InAppBrowser=2Ejava_so_?= =?utf-8?q?it_works_on_modern_devices?= Message-ID: <159897586070.32230.1537427306175395459.asfpy@gitbox.apache.org> Date: Tue, 01 Sep 2020 15:57:40 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: dpa99c commented on pull request #700: URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/700#issuecomment-684958777 This PR removes several existing features such as the postMessage API and `beforeload` event with no justification or replacement functionality. There are also some questionable additions such as hard-coded strings in a handful of languages. My feeling that in its current state this PR cannot be merged without breaking existing plugin functionality and the additional code is of questionable suitability for generic use by plugin users. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org