cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cordova-plugin-inappbrowser] dpa99c commented on pull request #700: Android - Changed InAppBrowser.java so it works on modern devices
Date Tue, 01 Sep 2020 15:57:40 GMT

dpa99c commented on pull request #700:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/700#issuecomment-684958777


   This PR removes several existing features such as the postMessage API and `beforeload`
event with no justification or 
   replacement functionality. There are also some questionable additions such as hard-coded
strings in a handful of languages.
   
   My feeling that in its current state this PR cannot be merged without breaking existing
plugin functionality and the additional code is of questionable suitability for generic use
by plugin users.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message