cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cordova-plugin-screen-orientation] mkranz opened a new issue #70: Screen lock NotSupportedError for orientation 'landscape', 'portrait'
Date Tue, 04 Aug 2020 05:06:05 GMT

mkranz opened a new issue #70:
URL: https://github.com/apache/cordova-plugin-screen-orientation/issues/70


   # Bug Report
   
   ## Problem
   
   `screen.orientation.lock` promise is always rejected with the error `NotSupportedError`
   
   ### What is expected to happen?
   
   Promise should be resolved successfully and screenlock occurs
   
   ### What does actually happen?
   
   Promise is rejected with NotSupportedError
   
   ## Information
   <!-- Include all relevant information that might help understand and reproduce the problem
-->
   
   The version prior to the merging of https://github.com/apache/cordova-plugin-screen-orientation/pull/66
worked as expected.
   
   It appears this [line ](https://github.com/apache/cordova-plugin-screen-orientation/blob/3c08d393ffe0df5fa16f7fcbab06c22648dcc3ed/www/screenorientation.js#L87)
was inadvertently changed such that it never checks if the orientation is supported, but will
always fail instead.
   
   Removing the quotes from 'orientation' should fix this issue
   
   
   ### Command or Code
   <!-- What command or code is needed to reproduce the problem? -->
   
   
   
   ### Environment, Platform, Device
   <!-- In what environment, on what platform or on which device are you experiencing the
issue? -->
   
   Tested on iOS 13.5.1  iPad Air 2 
   
   ### Version information
   <!-- 
   What are relevant versions you are using?
   For example:
   Cordova: Cordova CLI, Cordova Platforms, Cordova Plugins 
   Other Frameworks: Ionic Framework and CLI version
   Operating System, Android Studio, Xcode etc.
   -->
   
   Master
   
   ## Checklist
   <!-- Please check the boxes by putting an x in the [ ] like so: [x] -->
   
   - [x ] I searched for existing GitHub issues
   - [x ] I updated all Cordova tooling to most recent version
   - [x ] I included all the necessary information above
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message