cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cordova-electron] erisu opened a new pull request #160: feat: install devtool extensions for debug builds
Date Fri, 17 Jul 2020 07:30:03 GMT

erisu opened a new pull request #160:
URL: https://github.com/apache/cordova-electron/pull/160


   ### Motivation, Context & Description
   
   - Added support to install & enable developer tool extension
   - Centralize the fetching of platform's `package.json` in `util.js`
   - Updated `Api.version` to use centralized fetch method
   - Updated `Api.version` unit-test
   - New feature uses centralized fetch method
   - Added unit test for new feature
   
   **Details on New Feature**
   
   - New feature uses the dependency `electron-devtools-installer` to install the devtool
during project build.
   - This dependency is added to the Electron project only for debug builds.
   - Cordova's implementation does not support adding this dependency in any way to a release
build.
   - The dependency pre-provided extension keys to quickly install without knowing an ID [`electron-devtools-installer`
Extension Keys](https://github.com/MarshallOfSound/electron-devtools-installer/tree/v3.1.1#what-extensions-can-i-use).
     - `EMBER_INSPECTOR`
     - `REACT_DEVELOPER_TOOLS`
     - `BACKBONE_DEBUGGER`
     - `JQUERY_DEBUGGER`
     - `ANGULARJS_BATARANG`
     - `VUEJS_DEVTOOLS`
     - `REDUX_DEVTOOLS`
     - `REACT_PERF`
     - `CYCLEJS_DEVTOOL`
     - `APOLLO_DEVELOPER_TOOLS`
     - `MOBX_DEVTOOLS`
   - The extensions which are installed are fetched from the Chrome App Store.
   - If the extensions listed above does not contain an extension you need, you can lookup
use a Chrome Store App ID to install the extension. (Again only for debug builds.)
   
   ### Testing
   
   - `npm t`
   - `cordova build electron`
   - `cordova run electron --nobuild`
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message