cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cordova-plugin-camera] jcesarmobile opened a new pull request #612: fix(ios): tempFilePath called twice if using CameraUsesGeolocation
Date Fri, 19 Jun 2020 17:40:07 GMT

jcesarmobile opened a new pull request #612:
URL: https://github.com/apache/cordova-plugin-camera/pull/612


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   ios
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   When using `<preference name="CameraUsesGeolocation" value="true" />`, the image
is saved twice and calls tempFilePath, which could cause an infinite loop as reported on https://github.com/apache/cordova-plugin-camera/issues/591
(couldn't reproduce)
   
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Instead of doing as on https://github.com/apache/cordova-plugin-camera/pull/592, which
put increase of the timestamp inside the while to fix the possible infinite loop, this PR
fixes the problem of the image being saved twice.
   
   It removes the while because it was there for an older code that used an int that was incremented
until the file didn't exist and used that int for the image name. Now that uses the timestamp
and it's not called twice there is no need for the while.
   
   fixes https://github.com/apache/cordova-plugin-camera/issues/591
   closes https://github.com/apache/cordova-plugin-camera/pull/592
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform
(e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and
used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message