From issues-return-99398-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Wed May 27 11:57:36 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A5B05180626 for ; Wed, 27 May 2020 13:57:36 +0200 (CEST) Received: (qmail 52334 invoked by uid 500); 27 May 2020 11:57:36 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 52322 invoked by uid 99); 27 May 2020 11:57:35 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 May 2020 11:57:35 +0000 From: =?utf-8?q?GitBox?= To: issues@cordova.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bcordova-ios=5D_erisu_opened_a_new_pull_request_=23?= =?utf-8?q?873=3A_chore=3A_remove_unassigned_splash_image?= Message-ID: Date: Wed, 27 May 2020 11:57:35 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit erisu opened a new pull request #873: URL: https://github.com/apache/cordova-ios/pull/873 ### Motivation, Context & Description *Reasons for Removing* * Removes the unassigned launch image warning. * The image is assigned in the platform repo template, but on new project creation the image is unassigned because the prepare step removes the image from assignment. This is because config.xml does not have a `splash` tag by default. * Android does not show splash screen by default, for consistency iOS should not display splash screen as well. *Other Thoughts* * *IF* a default splash screen is desired, IMO, it is recommended that the default image and `config.xml` `splash` settings are in our default template repo (`cordova-app-hello-world`). * *IF* a default splash is desired, a default should exist on all core platforms which can be again configured in our default template repo. * It is also expected that an end user would replace the splash screen so it may not be required. ### Testing - `npm t` - `cordova platform add` - `cordova build` ### Checklist - [x] I've run the tests to see all new and existing tests pass ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org