cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cordova-ios] erisu opened a new pull request #873: chore: remove unassigned splash image
Date Wed, 27 May 2020 11:57:35 GMT

erisu opened a new pull request #873:
URL: https://github.com/apache/cordova-ios/pull/873


   ### Motivation, Context & Description
   
   *Reasons for Removing*
   * Removes the unassigned launch image warning.
   * The image is assigned in the platform repo template, but on new project creation the
image is unassigned because the prepare step removes the image from assignment. This is because
config.xml does not have a `splash` tag by default.
   * Android does not show splash screen by default, for consistency iOS should not display
splash screen as well.
   
   *Other Thoughts*
   * *IF* a default splash screen is desired, IMO, it is recommended that the default image
and `config.xml` `splash` settings are in our default template repo (`cordova-app-hello-world`).
   * *IF* a default splash is desired, a default should exist on all core platforms which
can be again configured in our default template repo.
   * It is also expected that an end user would replace the splash screen so it may not be
required.
   
   ### Testing
   
   - `npm t`
   - `cordova platform add`
   - `cordova build`
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message