cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [cordova-node-xcode] timbru31 commented on a change in pull request #109: Add targetName to paramter to getBuildProperty
Date Fri, 01 May 2020 13:49:01 GMT

timbru31 commented on a change in pull request #109:
URL: https://github.com/apache/cordova-node-xcode/pull/109#discussion_r418548417



##########
File path: lib/pbxProject.js
##########
@@ -2068,11 +2068,34 @@ pbxProject.prototype.removeFile = function (path, group, opt) {
 
 
 
-pbxProject.prototype.getBuildProperty = function(prop, build) {
+pbxProject.prototype.getBuildProperty = function(prop, build, targetName) {
     var target;
+    let validConfigs = [];
+
+    if(targetName) {

Review comment:
       ```suggestion
       if (targetName) {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message