From issues-return-98049-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Tue Jan 8 13:28:49 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D4053180652 for ; Tue, 8 Jan 2019 13:28:48 +0100 (CET) Received: (qmail 43610 invoked by uid 500); 8 Jan 2019 12:28:47 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 43592 invoked by uid 99); 8 Jan 2019 12:28:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jan 2019 12:28:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 66A4AC78D7 for ; Tue, 8 Jan 2019 12:28:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id KhovYwfzeAhF for ; Tue, 8 Jan 2019 12:28:46 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E24246112A for ; Tue, 8 Jan 2019 12:18:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 67906E00EA for ; Tue, 8 Jan 2019 12:18:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 285C22555E for ; Tue, 8 Jan 2019 12:18:00 +0000 (UTC) Date: Tue, 8 Jan 2019 12:18:00 +0000 (UTC) From: "Sudhish (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-12492) plugin.xml edit-config not working for attributes on manifest/application MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-12492?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D167370= 64#comment-16737064 ]=20 Sudhish commented on CB-12492: ------------------------------ edit-config is not working in config.xml in cordova.=C2=A0 *Ionic:* =C2=A0 =C2=A0=C2=A0 ionic (Ionic CLI) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 : = 4.5.0 =C2=A0=C2=A0 Ionic Framework =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 : @ionic/angular 4.0.0-rc.0 =C2=A0=C2=A0 @angular-devkit/build-angular : 0.11.4 =C2=A0=C2=A0 @angular-devkit/schematics=C2=A0 =C2=A0 : 7.1.4 =C2=A0=C2=A0 @angular/cli=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 : 7.1.4 =C2=A0=C2=A0 @ionic/angular-toolkit=C2=A0 =C2=A0 =C2=A0 =C2=A0 : 1.2.0 =C2=A0 *Cordova:* =C2=A0 =C2=A0=C2=A0 cordova (Cordova CLI) : 8.0.0 =C2=A0=C2=A0 Cordova Platforms =C2=A0 =C2=A0 : none =C2=A0=C2=A0 Cordova Plugins =C2=A0 =C2=A0 =C2=A0 : cordova-plugin-ionic-ke= yboard 2.1.3, cordova-plugin-ionic-webview 2.2.3, (and 18 other plugins) =C2=A0 *System:* =C2=A0 =C2=A0=C2=A0 ios-deploy : 1.9.2 =C2=A0=C2=A0 NodeJS =C2=A0 =C2=A0 : v8.11.4 (/usr/local/bin/node) =C2=A0=C2=A0 npm=C2=A0 =C2=A0 =C2=A0 =C2=A0 : 5.6.0 =C2=A0=C2=A0 OS =C2=A0 =C2=A0 =C2=A0 =C2=A0 : macOS High Sierra > plugin.xml edit-config not working for attributes on manifest/application > ------------------------------------------------------------------------- > > Key: CB-12492 > URL: https://issues.apache.org/jira/browse/CB-12492 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-common > Affects Versions: 2.0.0 > Reporter: Matthias > Assignee: Filip Maj > Priority: Major > > h3. Environment > Cordova: 6.5.0 > CordovaCommon: 2.0.0 > CordovaAndroid: 6.1.2 > h3. Description > Using the edit-config in a plugin.xml to add an additional attribute on t= he manifest or application tag in AndroidManifest.xml does not work. > h3. Steps to reproduce > - Create new cordova project with android platform > - (Copy initial AndroidManifest.xml for comparison) > - Add cordova plugin which uses the edit-config setting to add a new attr= ibute to manifest or application tag > - Compare updated AndroidManifist.xml and see attribute was not added > h3. Expectation > Edit-config setting in plugin.xml allows to add/alter as well attributes = on manifest/application/... level in AndroidManifest.xml > ---- > h3. Example > This will work > {code:xml} > > > > {code} > This will *NOT* work > {code:xml} > > > > > > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org