From issues-return-97728-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Fri Nov 23 15:45:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D3184180660 for ; Fri, 23 Nov 2018 15:45:04 +0100 (CET) Received: (qmail 72871 invoked by uid 500); 23 Nov 2018 14:45:04 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 72854 invoked by uid 99); 23 Nov 2018 14:45:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Nov 2018 14:45:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 6E73DCD588 for ; Fri, 23 Nov 2018 14:45:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id fii7SzjJPO5k for ; Fri, 23 Nov 2018 14:45:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2C9395F341 for ; Fri, 23 Nov 2018 14:45:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 72837E02E3 for ; Fri, 23 Nov 2018 14:45:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1930321094 for ; Fri, 23 Nov 2018 14:45:00 +0000 (UTC) Date: Fri, 23 Nov 2018 14:45:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-13837) TypeScript Definition for CameraPopoverOptions does not declare class MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-13837?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D166972= 24#comment-16697224 ]=20 ASF GitHub Bot commented on CB-13837: ------------------------------------- jcesarmobile opened a new pull request #379: CB-13837: fix TypeScript Defin= ition for CameraPopoverOptions URL: https://github.com/apache/cordova-plugin-camera/pull/379 =20 =20 =20 ### Platforms affected all =20 ### What does this PR do? Fix TypeScript Definition for CameraPopoverOptions =20 ### What testing has been done on this change? Used in a TypeScript project and see that linter didn't complain after t= he change =20 ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.ht= ml) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug wit= h resolving file paths", where CB-xxxx is the JIRA ID & "android" is the pl= atform affected. - [ ] Added automated test coverage as appropriate for this change. =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > TypeScript Definition for CameraPopoverOptions does not declare class > --------------------------------------------------------------------- > > Key: CB-13837 > URL: https://issues.apache.org/jira/browse/CB-13837 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Reporter: Ryan Murphy > Priority: Minor > > The docs for CameraPopoverOptions use it as a class. > From docs:=C2=A0 > {code:javascript} > var cameraPopoverOptions =3D new CameraPopoverOptions(0, 0, 100, 100, Cam= era.PopoverArrowDirection.ARROW_ANY); > {code} > =C2=A0 > But the index.d.ts=C2=A0only define an interface,=C2=A0not declare a clas= s, so using it as a class in a TypeScript file gives the error: > {color:#ff0000}[ts] 'CameraPopoverOptions' only refers to a type, but is= being used as a value here.{color} > The fix would be to declare a class and constructor. > {code:java} > declare class CameraPopoverOptions implements CameraPopoverOptions { > constructor(x?: number, y?: number, width?: number, height?: number, = arrowDir?: number); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org