From issues-return-97743-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Sat Nov 24 13:54:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 012CA180675 for ; Sat, 24 Nov 2018 13:54:04 +0100 (CET) Received: (qmail 24612 invoked by uid 500); 24 Nov 2018 12:54:04 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 24601 invoked by uid 99); 24 Nov 2018 12:54:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 24 Nov 2018 12:54:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 98EE6D59A9 for ; Sat, 24 Nov 2018 12:54:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ikDKJWhFnQht for ; Sat, 24 Nov 2018 12:54:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 9643F5F35B for ; Sat, 24 Nov 2018 12:54:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1A717E0E33 for ; Sat, 24 Nov 2018 12:54:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A77CE21094 for ; Sat, 24 Nov 2018 12:54:00 +0000 (UTC) Date: Sat, 24 Nov 2018 12:54:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-13055) remove --nofetch option and all old fetching code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697801#comment-16697801 ] ASF GitHub Bot commented on CB-13055: ------------------------------------- janpio commented on a change in pull request #624: CB-13055 Fold all fetch options to `true` URL: https://github.com/apache/cordova-lib/pull/624#discussion_r236041699 ########## File path: src/plugman/fetch.js ########## @@ -63,22 +63,10 @@ function fetchPlugin (plugin_src, plugins_dir, options) { if (result) { if (result[1]) { options.git_ref = result[1]; } if (result[2]) { options.subdir = result[2]; } - // if --fetch was used, throw error for subdirectories + // throw error for subdirectories if (options.subdir && options.subdir !== '.') { - events.emit('warn', 'support for subdirectories is deprecated and will be removed in Cordova@7'); - if (options.fetch) { - return Q.reject(new CordovaError('--fetch does not support subdirectories')); - } - } - - // Recurse and exit with the new options and truncated URL. - var new_dir = plugin_src.substring(0, plugin_src.indexOf('#')); - - // skip the return if user asked for --fetch - // cordova-fetch doesn't need to strip out git-ref - if (!options.fetch) { - return fetchPlugin(new_dir, plugins_dir, options); + return Q.reject(new CordovaError('Cordova does not support subdirectories')); Review comment: Ugh, this broke the documented way to install plugin tests: https://github.com/apache/cordova-plugin-test-framework#tldr-try-it ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > remove --nofetch option and all old fetching code > ------------------------------------------------- > > Key: CB-13055 > URL: https://issues.apache.org/jira/browse/CB-13055 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib > Reporter: Steve Gill > Assignee: Raphael > Priority: Major > Labels: backlog, tools-next > Fix For: cordova@8 > > > Cordova uses cordova-fetch for fetching modules by default now. In the next major version, lets drop the older methods. This is great for reducing maintenance in cordova. Original fetch proposal is at https://github.com/cordova/cordova-discuss/pull/33 > remove --nofetch option > remove lazy_load > remove gitclone.js > remove npm dependency > remove remoteload.js > update anywhere that these files are used > Proposal: https://github.com/apache/cordova-discuss/pull/76 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org