cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14201) Remove Gradle property in-line command arguments for gradle.properties
Date Thu, 01 Nov 2018 04:26:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671110#comment-16671110
] 

ASF subversion and git services commented on CB-14201:
------------------------------------------------------

Commit e58453d3e6f16e45fb9ac3b9f420832799c57e91 in cordova-android's branch refs/heads/master
from [~dpogue]
[ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=e58453d ]

Merge pull request #465 from erisu/CB-14201

CB-14201: (android) Removes Gradle property in-line command arguments…

> Remove Gradle property in-line command arguments for gradle.properties
> ----------------------------------------------------------------------
>
>                 Key: CB-14201
>                 URL: https://issues.apache.org/jira/browse/CB-14201
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-android
>            Reporter: Bryan Ellis
>            Priority: Minor
>
> By passing in properties as an argument to the Gradle's command, it prevents users from
being able to override these values. 
> In one example, a user reported ([CB-14139|https://issues.apache.org/jira/browse/CB-14139])
the need to be able to set the jvmargs so builds works on 32bit Java.
> Some other values Cordova passes by default are org.gradle.daemon and android.useDeprecatedNdk.
> By removing the command line argument usage and migrating to the usage of gradle.properties,
it gives users the flexibility to override defaults if desired.  
> This ticket will also resolve [CB-14139|https://issues.apache.org/jira/browse/CB-14139]
but also remove the other argument usage.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message