cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14089) Add Kotlin Support
Date Mon, 12 Nov 2018 17:33:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684143#comment-16684143
] 

ASF GitHub Bot commented on CB-14089:
-------------------------------------

brodybits commented on a change in pull request #441: CB-14089: (android) Add Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r232747948
 
 

 ##########
 File path: bin/templates/project/app/build.gradle
 ##########
 @@ -30,13 +34,16 @@ buildscript {
 
     dependencies {
         classpath 'com.android.tools.build:gradle:3.1.0'
+        if (cdvHelpers.getConfigPreference('EnableKotlin', 'false').toBoolean()) {
+            classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
+        }
     }
 }
 
 // Allow plugins to declare Maven dependencies via build-extras.gradle.
 allprojects {
     repositories {
-        mavenCentral();
+        mavenCentral()
 
 Review comment:
   I think this should be proposed in a separate PR (this may be done in PR #507).
   
   Also I think removing semicolons should be proposed in a separate PR. (EDIT: already proposed
in PR #507)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add Kotlin Support
> ------------------
>
>                 Key: CB-14089
>                 URL: https://issues.apache.org/jira/browse/CB-14089
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: cordova-android
>            Reporter: Joshua Chandler
>            Assignee: Joe Bowser
>            Priority: Minor
>             Fix For: cordova-android-7.0.0
>
>
> Kotlin is not supported out of the gate for cordova android projects.. You need to explicitly
configure a built android project to support it.  This should be supported out of the gate
with no configuration so that plugins or any other custom code could be written in the language.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message