cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13813) Remove old iOS code from cordova-plugin-camera
Date Fri, 23 Nov 2018 23:13:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697547#comment-16697547
] 

ASF GitHub Bot commented on CB-13813:
-------------------------------------

jcesarmobile opened a new pull request #381: CB-13813: (iOS) Remove old iOS code
URL: https://github.com/apache/cordova-plugin-camera/pull/381
 
 
   
   
   ### Platforms affected
   iOS
   
   ### What does this PR do?
   It removes iOS 8 checks as  cordova-ios only support iOS 9 and newer. (might still be breaking
change?)
   Removed the deprecated UIAlertView
   Reworked the logic about requesting/checking permissions so it doesn't present the camera
picker if the permission is not granted. As side effect of this, also fixes CB-14082, which
had another [PR](https://github.com/apache/cordova-plugin-camera/pull/321) that won't be needed

   
   ### What testing has been done on this change?
   
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove old iOS code from cordova-plugin-camera
> ----------------------------------------------
>
>                 Key: CB-13813
>                 URL: https://issues.apache.org/jira/browse/CB-13813
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-plugin-camera
>            Reporter: jcesarmobile
>            Assignee: jcesarmobile
>            Priority: Major
>
> cordova-ios supports iOS 9 and newer, but cordova-plugin-camera still has IsAtLeastiOSVersion(@"8.0")
code that is not needed. Also used UIAlertView which is deprecated
> We should remove all the IsAtLeastiOSVersion(@"8.0") and replace the UIAlertView with
UIAlertController and some other old unused code



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message