cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13569) The LocalFileSystem enum in the typescript file is inverted
Date Fri, 23 Nov 2018 16:05:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697307#comment-16697307
] 

ASF GitHub Bot commented on CB-13569:
-------------------------------------

jcesarmobile opened a new pull request #274: CB-13569: fix inverted LocalFileSystem enum
URL: https://github.com/apache/cordova-plugin-file/pull/274
 
 
   [This]( https://github.com/apache/cordova-plugin-file/pull/224) was sent by an user, but
they closed it because the title was not fine and never resubmitted.
   
   I've checked that it works without the change because it takes the JavaScript value, but
changed the value in the .ts for consistency.
   
   ### Platforms affected
   
   
   ### What does this PR do?
   Fix inverted LocalFileSystem enum
   
   ### What testing has been done on this change?
   
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> The LocalFileSystem enum in the typescript file is inverted
> -----------------------------------------------------------
>
>                 Key: CB-13569
>                 URL: https://issues.apache.org/jira/browse/CB-13569
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-file
>         Environment: Problem when using typescript.
>            Reporter: anton deblasio
>            Priority: Trivial
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> When using the typescript type file one of the enums is inverted
>  the LocalFileSystem has two options PERSISTENT and TEMPORARY, these relate to the values
1 and 0 respectively.  However in the typescript file they are set to 0 and 1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message