cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13055) remove --nofetch option and all old fetching code
Date Sat, 24 Nov 2018 15:34:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697855#comment-16697855
] 

ASF GitHub Bot commented on CB-13055:
-------------------------------------

janpio commented on a change in pull request #624: CB-13055 Fold all fetch options to `true`
URL: https://github.com/apache/cordova-lib/pull/624#discussion_r236045699
 
 

 ##########
 File path: src/plugman/fetch.js
 ##########
 @@ -63,22 +63,10 @@ function fetchPlugin (plugin_src, plugins_dir, options) {
         if (result) {
             if (result[1]) { options.git_ref = result[1]; }
             if (result[2]) { options.subdir = result[2]; }
-            // if --fetch was used, throw error for subdirectories
 
+            // throw error for subdirectories
             if (options.subdir && options.subdir !== '.') {
-                events.emit('warn', 'support for subdirectories is deprecated and will be
removed in Cordova@7');
-                if (options.fetch) {
-                    return Q.reject(new CordovaError('--fetch does not support subdirectories'));
-                }
-            }
-
-            // Recurse and exit with the new options and truncated URL.
-            var new_dir = plugin_src.substring(0, plugin_src.indexOf('#'));
-
-            // skip the return if user asked for --fetch
-            // cordova-fetch doesn't need to strip out git-ref
-            if (!options.fetch) {
-                return fetchPlugin(new_dir, plugins_dir, options);
+                return Q.reject(new CordovaError('Cordova does not support subdirectories'));
 
 Review comment:
   https://github.com/apache/cordova-lib/issues/722

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> remove --nofetch option and all old fetching code
> -------------------------------------------------
>
>                 Key: CB-13055
>                 URL: https://issues.apache.org/jira/browse/CB-13055
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-lib
>            Reporter: Steve Gill
>            Assignee: Raphael
>            Priority: Major
>              Labels: backlog, tools-next
>             Fix For: cordova@8
>
>
> Cordova uses cordova-fetch for fetching modules by default now. In the next major version,
lets drop the older methods. This is great for reducing maintenance in cordova. Original fetch
proposal is at https://github.com/cordova/cordova-discuss/pull/33
> remove --nofetch option
> remove lazy_load
> remove gitclone.js
> remove npm dependency
> remove remoteload.js
> update anywhere that these files are used
> Proposal: https://github.com/apache/cordova-discuss/pull/76



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message