cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-12210) Specifying the --plugin flag without a value causes an exception
Date Sat, 24 Nov 2018 17:18:00 GMT

    [ https://issues.apache.org/jira/browse/CB-12210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697895#comment-16697895
] 

ASF GitHub Bot commented on CB-12210:
-------------------------------------

janpio closed pull request #19: [CB-12210] require a string when parsing the plugin argument.
URL: https://github.com/apache/cordova-paramedic/pull/19
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/main.js b/main.js
index 6b95410..1b117ad 100755
--- a/main.js
+++ b/main.js
@@ -65,7 +65,9 @@ var USAGE           = "Error missing args. \n" +
     "--version : (optional) prints cordova-paramedic version and exits\n" +
     "";
 
-var argv = parseArgs(process.argv.slice(2));
+var argv = parseArgs(process.argv.slice(2), {
+    "string": ["plugin"]
+});
 var pathToParamedicConfig = util.getConfigPath(argv.config);
 
 if (argv.version) {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Specifying the --plugin flag without a value causes an exception
> ----------------------------------------------------------------
>
>                 Key: CB-12210
>                 URL: https://issues.apache.org/jira/browse/CB-12210
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-paramedic
>            Reporter: sterling gerritz
>            Assignee: Jesse MacFadyen
>            Priority: Minor
>
> FYI: when I failed to add a path paramedic threw a 'type error':
>  cordova-paramedic --platform android --plugin
> cordova-paramedic: creating temp project at /var/folders/p4/m50wzcnx3_5grsq_d3z5kq5w0000gn/T/tmp-21300Vfzeii04OHd0
> cordova-paramedic: installing true
> path.js:7
>    throw new TypeError('Path must be a string. Received ' + inspect(path));
>    ^
> TypeError: Path must be a string. Received true
>    at assertPath (path.js:7:11)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message