cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-10718) createmobilespec instructions incomplete for cordova-common
Date Sat, 24 Nov 2018 00:33:00 GMT

    [ https://issues.apache.org/jira/browse/CB-10718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697563#comment-16697563
] 

ASF GitHub Bot commented on CB-10718:
-------------------------------------

janpio commented on a change in pull request #145: CB-10718: Update instruction
URL: https://github.com/apache/cordova-mobile-spec/pull/145#discussion_r236027970
 
 

 ##########
 File path: createmobilespec/createmobilespec.js
 ##########
 @@ -345,16 +345,13 @@ if (argv.global) {
 
     console.log("To clone repositories:");
     console.log(["  ." + path.sep + "cordova-coho" + path.sep + "coho repo-clone"].concat(repos).join("
-r "));
-    if (!argv.globalplugins) {
-        console.log("  mkdir cordova-cli" + path.sep + "node_modules");
-        console.log("  (cd cordova-lib && npm install)");
-        console.log("  (cd cordova-plugman" + path.sep + " && npm install)");
-        console.log("  mkdir cordova-cli" + path.sep + "node_modules");
-        console.log("  ln -s .." + path.sep + ".." + path.sep + "cordova-lib cordova-cli"
+ path.sep + "node_modules");
-        console.log("  (cd cordova-cli && npm install)");
-    }
+    console.log("  ." + path.sep + "cordova-coho" + path.sep + "coho -r cli -r common -r
create -r fetch -r js -r serve -r lib -r plugman \"npm install\"");
 
 Review comment:
   What does this line do?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> createmobilespec instructions incomplete for cordova-common
> -----------------------------------------------------------
>
>                 Key: CB-10718
>                 URL: https://issues.apache.org/jira/browse/CB-10718
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-mobile-spec
>            Reporter: Shazron Abdullah
>            Priority: Major
>              Labels: triaged
>
> {code}
> $ ./cordova-mobile-spec/createmobilespec/createmobilespec.js --ios
> Creating project from local git repos. If you have any errors, it may be from missing
repositories.
> To clone repositories:
>   ./cordova-coho/coho repo-clone -r mobile-spec -r plugin-test-framework -r cli -r lib
-r plugman -r ios -r js -r plugins
>   mkdir cordova-cli/node_modules
>   (cd cordova-lib/cordova-lib/ && npm install)
>   (cd cordova-plugman/ && npm install)
>   mkdir cordova-cli/node_modules
>   ln -s ../../cordova-lib/cordova-lib cordova-cli/node_modules
>   (cd cordova-cli && npm install)
> To update all repositories:
>   ./cordova-coho/coho repo-update
> Checking if you are using master branch of tools
> refs/heads/master
> refs/heads/master
> refs/heads/master
> refs/heads/master
> You are on master branch of tools, checking npm links
> npm links are OK
> Creating project mobilespec...
> module.js:338
>     throw err;
>           ^
> Error: Cannot find module 'ansi'
>     at Function.Module._resolveFilename (module.js:336:15)
>     at Function.Module._load (module.js:278:25)
>     at Module.require (module.js:365:17)
>     at require (module.js:384:17)
>     at Object.<anonymous> (/Users/shazron/Documents/git/apache/cordova-lib/cordova-common/src/CordovaLogger.js:20:12)
>     at Module._compile (module.js:460:26)
>     at Object.Module._extensions..js (module.js:478:10)
>     at Module.load (module.js:355:32)
>     at Function.Module._load (module.js:310:12)
>     at Module.require (module.js:365:17)
> {code}
> It should instruct you to run "npm install" inside cordova-lib/cordova-common as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message