From issues-return-97070-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Thu Sep 6 04:09:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7DEFD180654 for ; Thu, 6 Sep 2018 04:09:03 +0200 (CEST) Received: (qmail 41451 invoked by uid 500); 6 Sep 2018 02:09:02 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 41440 invoked by uid 99); 6 Sep 2018 02:09:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Sep 2018 02:09:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 1FC25C1E77 for ; Thu, 6 Sep 2018 02:09:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ILiPtTxZOvU4 for ; Thu, 6 Sep 2018 02:09:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id DAFDB5F3F4 for ; Thu, 6 Sep 2018 02:09:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5AC11E00A5 for ; Thu, 6 Sep 2018 02:09:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 161302183F for ; Thu, 6 Sep 2018 02:09:00 +0000 (UTC) Date: Thu, 6 Sep 2018 02:09:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-14108) in config.xml increases config_munge count in ios.json and android.json. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-14108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605172#comment-16605172 ] ASF GitHub Bot commented on CB-14108: ------------------------------------- knight9999 commented on issue #24: CB-14108: fix incorrect count in config_munge in ios.json and android.json URL: https://github.com/apache/cordova-common/pull/24#issuecomment-418940100 @janpio I see. I have updated the title. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > in config.xml increases config_munge count in ios.json and android.json. > -------------------------------------------------------------------------------------- > > Key: CB-14108 > URL: https://issues.apache.org/jira/browse/CB-14108 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-common, cordova-lib > Affects Versions: 8.0.0 > Reporter: Ken Naito > Priority: Major > Fix For: Master > > > On both iOS and Android platforms, using causes duplication in the `ios.json` and `android.json` files, which could lead to extremely large file sizes (and possibly unexpected behaviour?). > For a Cordova 7.1/8.0 application, add the following to config.xml: > > {code:java} > > > > > Please permit Camera! > > > {code} > Now run `cordova prepare`. The file `platforms/ios/ios.json` now contains the below. Note the count is 1. > > {code:java} > "config_munge": { > "files": { > "*-Info.plist": { > "parents": { > "NSCameraUsageDescription": [ > { > "xml": "Please permit Camera!", > "count": 1 > } > ] > } > } > } > }, > {code} > Run `cordova prepare` again. The platforms/ios/ios.json changes, increasing the count to 2. > > {code:java} > "config_munge": { > "files": { > "*-Info.plist": { > "parents": { > "NSCameraUsageDescription": [ > { > "xml": "Please permit Camera!", > "count": 2 > } > ] > } > } > } > }, > {code} > Furthermore, if we change the text inside the `` in the `config.xml`: > {code:java} > > > > > This app uses Camera! > > > {code} > Then after running `cordova prepare`, there is now a second entry in `platforms/ios/ios.json`, rather than replacing the existing entry. > > {code:java} > "config_munge": { > "files": { > "*-Info.plist": { > "parents": { > "NSCameraUsageDescription": [ > { > "xml": "Please permit Camera!", > "count": 2 > }, > { > "xml": "This app uses Camera!", > "count": 1 > } > ] > } > } > } > }, > {code} > This behaviour is the same for Android, and can be reproduced in the same way, by adding something like the below to `config.xml`: > {code:java} > > > > > > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org