cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14225) Fix sample namespace Serialize attribute in template/Properties/Default.rd.xml
Date Sun, 02 Sep 2018 02:39:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16599903#comment-16599903
] 

ASF subversion and git services commented on CB-14225:
------------------------------------------------------

Commit 03f482dfee44809b9e289af3721eccb31884bc53 in cordova-windows's branch refs/heads/master
from [~brodybits]
[ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=03f482d ]

CB-14225 fix sample Namespace Serialize attribute in template/Properties/Default.rd.xml (#286)

### Original issue

<https://issues.apache.org/jira/browse/CB-14225>

### Platforms affected

Windows

### What does this PR do?

- Fix sample Namespace Serialize attribute in `template/Properties/Default.rd.xml`, according
to `Default.rd.xml` in C# UWP project generated by Visual Studio 2017

I also raised <https://github.com/Microsoft/Windows-universal-samples/pull/950> to apply
a similar fix there.

Also related:
- #284 - fix license text & add link to `template/Properties/Default.rd.xml` (as reported
in <https://issues.apache.org/jira/browse/CB-14224>)
- <https://github.com/Microsoft/Windows-universal-samples/pull/949> - fix license txt
(related to but not part of #284)

### What testing has been done on this change?

- Visual inspection
- check diff

### Checklist

- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths",
where CB-xxxx is the JIRA ID & "android" is the platform affected.
- ~~Added automated test coverage as appropriate for this change.~~

> Fix sample namespace Serialize attribute in template/Properties/Default.rd.xml
> ------------------------------------------------------------------------------
>
>                 Key: CB-14225
>                 URL: https://issues.apache.org/jira/browse/CB-14225
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-windows
>            Reporter: Chris Brody
>            Assignee: Chris Brody
>            Priority: Minor
>
> If I would generate a new UWP C# project using Visual Studio 2017 and copy the generated
{{Default.rd.xml}} file into {{template\Properties}} then I would see the following diff:
> {code:xml}
> index 7c40ffeb..af00722c 100644
> --- a/template/Properties/Default.rd.xml
> +++ b/template/Properties/Default.rd.xml
> @@ -12,7 +12,7 @@
>      <TypeInstantiation Name="App1.AppClass" Arguments="System.Int32" Activate="Required
Public" />
>      Using the Namespace directive to apply reflection policy to all the types in a particular
namespace
> -    <Namespace Name="DataClasses.ViewModels" Seralize="All" />
> +    <Namespace Name="DataClasses.ViewModels" Serialize="All" />
>  -->
>  <Directives xmlns="http://schemas.microsoft.com/netfx/2013/01/metadata">
> {code}
> I propose to commit this change to the master branch.
> Related:
> * CB-12499 - introduced {{template/Properties/Default.rd.xml}}
> * CB-14224 - proposal to add license text to the header
> * [Microsoft/Windows-universal-samples#950|https://github.com/Microsoft/Windows-universal-samples/pull/950]
- similar proposal for [Microsoft / Windows-universal-samples|https://github.com/Microsoft/Windows-universal-samples]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message