cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera
Date Sat, 29 Sep 2018 22:55:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633143#comment-16633143
] 

ASF GitHub Bot commented on CB-13307:
-------------------------------------

DavidBriglio opened a new pull request #286: CB-13307: (Android) Fixed issue when unable to
load image with mime t…
URL: https://github.com/apache/cordova-plugin-camera/pull/286
 
 
   …ype "image/*", and failing to recognize new contentprovider uri authority.
   
   ### Platforms affected
   Android
   
   ### What does this PR do?
   Allows for image mimetype "image/*" to be accepted as a valid image.
   Allows for google photos uri authority ".contentprovider" to be recognized.
   
   ### What testing has been done on this change?
   When running "npm test" results in "invalid config loglevel='notice'".
   When running "npm run test-build" results in "missing script: test-build".
   Manual testing has been done on Android 8.0 Google Pixel with cordova cli 6.5.0.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Accessing Google Photos on Pixel from cordova-plugin-camera
> -----------------------------------------------------------
>
>                 Key: CB-13307
>                 URL: https://issues.apache.org/jira/browse/CB-13307
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-camera
>            Reporter: David Briglio
>            Priority: Major
>
> Currently when trying to access some photos from Google Photos, it fails to load. Android
8.0 on Google Pixel, cordova version 6.5.0, cordova-plugin-camera version 2.4.1.
> Causes:
> 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types are considered
an invalid image. The mimetype of the image I am loading gets set to "image/*".
> 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri authority is
compared against "com.google.android.apps.photos.content", where the actual is "com.google.android.apps.photos.contentprovider".
This causes the logic to dismiss the image as not from Google Photos.
> After applying fixes for these two areas, I am able to successfully load all of my images.
> Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/286].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message