cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-13123) plugin add should use cordovaDependency instead of plugin.xml engine tag
Date Wed, 05 Sep 2018 10:23:00 GMT

    [ https://issues.apache.org/jira/browse/CB-13123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604240#comment-16604240
] 

ASF GitHub Bot commented on CB-13123:
-------------------------------------

janpio commented on issue #598: CB-13123 : plugin add should use cordovaDependency instead
URL: https://github.com/apache/cordova-lib/pull/598#issuecomment-418679637
 
 
   Next to failing tests this PR now also has conflicts. Could you please rebase on master
@audreyso and fix those? Then we can take another look at those test failures. Thank you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> plugin add should use cordovaDependency instead of plugin.xml engine tag
> ------------------------------------------------------------------------
>
>                 Key: CB-13123
>                 URL: https://issues.apache.org/jira/browse/CB-13123
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-lib
>            Reporter: Steve Gill
>            Assignee: Audrey So
>            Priority: Major
>              Labels: tools-next
>             Fix For: cordova@8
>
>
> We have been planning on switching from plugin.xml engine tag to cordovaDependencies
element in package.json when it comes to resolving project dependencies during plugin add.

> I suggest we update the code to use cordovaDependencies. Maybe we fallback on plugin.xml
engine element until we do a major cordova release where we drop engine element fully.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message