cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14263) Makes all of cordova plugins compatible with cordova-android 7
Date Wed, 08 Aug 2018 17:53:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573586#comment-16573586
] 

ASF GitHub Bot commented on CB-14263:
-------------------------------------

leo6104 opened a new pull request #35:  CB-14263: (android) make cordova plugin compatible
with cordova-android 7
URL: https://github.com/apache/cordova-common/pull/35
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   cordova-android
   
   ### What does this PR do?
   My PR supports alias path in cordova-plugin config-file tag. 
   It will makes older cordova plugins's android config-file target compatible with cordova-android
7.
   
   There is lots of problem with cordova-android 7 & cordova plugins. Many of cordova
plugins still not upgraded to cordova-android 7 and there is limitation to wait for them to
update their plugin.xml. So i think we need 
   
   ### What testing has been done on this change?
   I create cordova-android 7 project with install cordova-plugin-device (only cordova-android
<=6 support plugin) 
   and install via `npm i -g https://github.com/leo6104/cordova-cli.git` 
   and run `cordova build android` 
   and check `platforms/android/app/src/main/res/xml/config.xml` to correctly inject <feature>
tag
   
   I also test this commit to my production hybrid app (30k~40k user scale DAU app - 14 cordova
plugins)
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Makes all of cordova plugins compatible with cordova-android 7
> --------------------------------------------------------------
>
>                 Key: CB-14263
>                 URL: https://issues.apache.org/jira/browse/CB-14263
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: AllPlugins, cordova-android, cordova-common
>    Affects Versions: cordova-common@2.2.3
>            Reporter: Heo
>            Priority: Major
>             Fix For: Master
>
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> Cordova common's ConfigParser supports alias such as config.xml, AndroidManifest.xml
paths. [https://github.com/apache/cordova-common/blob/7bf9627f0135c6b3518292660b6e07e6f5815926/src/ConfigChanges/ConfigFile.js#L192] But
In PluginInfo parser, there is no alias rules for compatibility.
> There is lots of cordova plugins still not upgrade to cordova-android 7 syntax (plugin.xml)
> So i did some changes to cordova-common which will make cordova cli parsing some plugins
which not support cordova-android 7 yet.
> [https://github.com/apache/cordova-cli/compare/master...leo6104:master]
> Here is my changes.
>  
>  
> I spent lots of times to fix this. I test it via my cutsom cordova-cli repository [https://github.com/leo6104/cordova-cli/] and
i fix it in my cordova project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message