cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14238) Statusbar transparency does not persist when hiding and showing the statusbar
Date Wed, 01 Aug 2018 04:17:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564710#comment-16564710
] 

ASF GitHub Bot commented on CB-14238:
-------------------------------------

brodybits commented on issue #99: CB-14238: Make transparency of statusbar persistent when
hiding and showing statusbar
URL: https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409443946
 
 
   A couple minor points FYI:
   - First line should generally be within 50 characters. If you need more then you should
add a blank line then keep remaining lines within 70 characters. This is very well documented,
for example: <https://chris.beams.io/posts/git-commit/>. AFAICT we generally take care
of this formatting issue if needed.
   - Unless there is good reason to keep multiple original commits we will very likely do
a "squash merge", which means that the master branch would actually diverge from your proposed
`android-persistent-transparency` branch.
   
   Thanks for the contribution, I am sure it will help others in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Statusbar transparency does not persist when hiding and showing the statusbar
> -----------------------------------------------------------------------------
>
>                 Key: CB-14238
>                 URL: https://issues.apache.org/jira/browse/CB-14238
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-statusbar
>         Environment: Android
>            Reporter: Adam Szmyd
>            Priority: Minor
>              Labels: android, easyfix, transparency
>
> When you call methods in this order: {{overlaysWebView(true)}} , {{hide()}} , {{show()}} the
status bar gets shown without transparency and pushes webview to bottom. And because at start
statusbar gets transparent (overlaysWebView) from this point the show/hide should toggle the
statusbar visibility and it should always show transparent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message