From issues-return-96417-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Fri Jul 27 02:28:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4FD5B180677 for ; Fri, 27 Jul 2018 02:28:04 +0200 (CEST) Received: (qmail 16022 invoked by uid 500); 27 Jul 2018 00:28:03 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 15854 invoked by uid 99); 27 Jul 2018 00:28:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jul 2018 00:28:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C48C5C87F6 for ; Fri, 27 Jul 2018 00:28:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id uVGlT86bla0f for ; Fri, 27 Jul 2018 00:28:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BF1115F42E for ; Fri, 27 Jul 2018 00:28:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 29B37E25C9 for ; Fri, 27 Jul 2018 00:28:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id BE38627761 for ; Fri, 27 Jul 2018 00:28:00 +0000 (UTC) Date: Fri, 27 Jul 2018 00:28:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-14224) template/Properties/Default.rd.xml needs license header MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-14224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559077#comment-16559077 ] ASF GitHub Bot commented on CB-14224: ------------------------------------- brodybits opened a new pull request #285: CB-14224 Default.rd.xml updates (6.0.x patch) URL: https://github.com/apache/cordova-windows/pull/285 ### Original issue ### Platforms affected Windows ### What does this PR do? Proposed `template/Properties/Default.rd.xml` updates in 6.0.x patch release, as rebased & squashed from #284: - add MIT license text from , with left aligment fixed - add link to As I said in #284 I think this is desired to satisfy the Apache RAT tool (used by `coho audit-license-headers`). Alternative may be to add an exception for this file but I think it would be better to follow the standard Apache procedure if possible. ### What testing has been done on this change? I verified that `coho audit-license-headers -r windows` with these changes does not show the missing license header any more. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. - ~~Added automated test coverage as appropriate for this change.~~ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > template/Properties/Default.rd.xml needs license header > ------------------------------------------------------- > > Key: CB-14224 > URL: https://issues.apache.org/jira/browse/CB-14224 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows > Reporter: Chris Brody > Assignee: Chris Brody > Priority: Minor > > Running {{coho audit-license-headers -r windows}} gives a message that {{template/Properties/Default.rd.xml}} is missing the license header. From a quick search I found {{Default.rd.xml}} in [Microsoft / Windows-universal-samples / SharedContent / cs / Default.rd.xml (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml] which is exactly the same except for a {{http}} link that was updated to {{https}} _(update: old {{http}} link in GitHub, no need to update this one)_. I would like to propose the following changes: > * -Updated {{https}} link from [Microsoft / Windows-universal-samples / SharedContent / cs / Default.rd.xml (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml]- > * Include license text from [Microsoft / Windows-universal-samples / LICENSE (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/LICENSE] (with left alignment fixed) > * Link to [Microsoft / Windows-universal-samples / SharedContent / cs / Default.rd.xml (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml] in {{template/Properties/Default.rd.xml}} > _Additional notes:_ > - _{{template/Properties/Default.rd.xml}} was introduced in CB-12499._ > - _I raised [Microsoft/Windows-universal-samples#949|https://github.com/Microsoft/Windows-universal-samples/pull/949] to cleanup (and rename) its LICENSE file. This may influence the exact LICENSE text we should include in {{template/Properties/Default.rd.xml}}._ > - _Another fix to {{template/Properties/Default.rd.xml}} is proposed in CB-14225_ -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org