From issues-return-96234-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Mon Jul 16 20:23:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8EF7418076D for ; Mon, 16 Jul 2018 20:23:04 +0200 (CEST) Received: (qmail 93353 invoked by uid 500); 16 Jul 2018 18:23:03 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 93215 invoked by uid 99); 16 Jul 2018 18:23:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Jul 2018 18:23:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 2E3ABC230B for ; Mon, 16 Jul 2018 18:23:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.5 X-Spam-Level: X-Spam-Status: No, score=-109.5 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100, WEIRD_QUOTING=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id ZG4bhA1k-3S9 for ; Mon, 16 Jul 2018 18:23:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 8A7D45F300 for ; Mon, 16 Jul 2018 18:23:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 035E4E0FD0 for ; Mon, 16 Jul 2018 18:23:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5C07B23F9C for ; Mon, 16 Jul 2018 18:23:00 +0000 (UTC) Date: Mon, 16 Jul 2018 18:23:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545578#comment-16545578 ] ASF GitHub Bot commented on CB-14166: ------------------------------------- AlmirKadric edited a comment on issue #622: CB-14166: (cli) Fixed issue when installing plugins on windows URL: https://github.com/apache/cordova-lib/pull/622#issuecomment-405334374 Final test completed, these are the errors that appear when I tested latest master with my patch applied (rebased). As you can see my patch fixes quite a lot of the issues. I would argue any remaining issues are out of scope of this PR and should be addressed separately. Will push up rebased fix.
Full Error Set

``` 1) end-to-end plugin dependency tests Test 033 : should use a dev version of a dependent plugin if it is already installed Message: CordovaError: Failed to fetch plugin https://github.com/apache/cordova-plugin-file via registry. Probably this is either a connection problem, or plugin spec is incorrect. Check your connection and plugin name/version/URL. Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit code 1 Error output: npm ERR! code 128 npm ERR! Command failed: C:\Program Files\Git\cmd\git.EXE submodule update -q --init --recursive npm ERR! fatal: 'submodule' appears to be a git command, but we were not npm ERR! able to execute it. Maybe git-submodule is broken? npm ERR! npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\almir\AppData\Roaming\npm-cache\_logs\2018-07-16T17_05_08_799Z-debug.log Stack: error properties: undefined at at D:\Dump\cordova-lib\src\plugman\fetch.js:147:37 at _rejected (D:\Dump\cordova-lib\node_modules\q\q.js:864:24) at D:\Dump\cordova-lib\node_modules\q\q.js:890:30 at Promise.when (D:\Dump\cordova-lib\node_modules\q\q.js:1142:31) at Promise.promise.promiseDispatch (D:\Dump\cordova-lib\node_modules\q\q.js:808:41) at D:\Dump\cordova-lib\node_modules\q\q.js:624:44 at runSingle (D:\Dump\cordova-lib\node_modules\q\q.js:137:13) at flush (D:\Dump\cordova-lib\node_modules\q\q.js:125:13) at process._tickCallback (internal/process/next_tick.js:61:11) 2) tests platform/spec restore with --save Test#017 : test to make sure that platform url is added and restored properly Message: CordovaError: Failed to fetch platform https://github.com/apache/cordova-browser Probably this is either a connection problem, or platform spec is incorrect. Check your connection and platform name/version/URL. Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit code 1 Error output: npm ERR! code 128 npm ERR! Command failed: C:\Program Files\Git\cmd\git.EXE submodule update -q --init --recursive npm ERR! fatal: 'submodule' appears to be a git command, but we were not npm ERR! able to execute it. Maybe git-submodule is broken? npm ERR! npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\almir\AppData\Roaming\npm-cache\_logs\2018-07-16T17_05_52_851Z-debug.log Stack: error properties: undefined at at D:\Dump\cordova-lib\src\cordova\platform\addHelper.js:305:25 at _rejected (D:\Dump\cordova-lib\node_modules\q\q.js:864:24) at D:\Dump\cordova-lib\node_modules\q\q.js:890:30 at Promise.when (D:\Dump\cordova-lib\node_modules\q\q.js:1142:31) at Promise.promise.promiseDispatch (D:\Dump\cordova-lib\node_modules\q\q.js:808:41) at D:\Dump\cordova-lib\node_modules\q\q.js:624:44 at runSingle (D:\Dump\cordova-lib\node_modules\q\q.js:137:13) at flush (D:\Dump\cordova-lib\node_modules\q\q.js:125:13) at process._tickCallback (internal/process/next_tick.js:61:11) 3) tests platform/spec restore with --save Test#018 : test to make sure that plugin url is added and restored properly Message: CordovaError: Failed to fetch plugin https://github.com/apache/cordova-plugin-splashscreen via registry. Probably this is either a connection problem, or plugin spec is incorrect. Check your connection and plugin name/version/URL. Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit code 1 Error output: npm ERR! code 128 npm ERR! Command failed: C:\Program Files\Git\cmd\git.EXE submodule update -q --init --recursive npm ERR! fatal: 'submodule' appears to be a git command, but we were not npm ERR! able to execute it. Maybe git-submodule is broken? npm ERR! npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\almir\AppData\Roaming\npm-cache\_logs\2018-07-16T17_05_57_078Z-debug.log Stack: error properties: undefined at at D:\Dump\cordova-lib\src\plugman\fetch.js:147:37 at _rejected (D:\Dump\cordova-lib\node_modules\q\q.js:864:24) at D:\Dump\cordova-lib\node_modules\q\q.js:890:30 at Promise.when (D:\Dump\cordova-lib\node_modules\q\q.js:1142:31) at Promise.promise.promiseDispatch (D:\Dump\cordova-lib\node_modules\q\q.js:808:41) at D:\Dump\cordova-lib\node_modules\q\q.js:624:44 at runSingle (D:\Dump\cordova-lib\node_modules\q\q.js:137:13) at flush (D:\Dump\cordova-lib\node_modules\q\q.js:125:13) at process._tickCallback (internal/process/next_tick.js:61:11) 4) plugin end-to-end Test 009 : should not check npm info when fetching from a Git repository Message: CordovaError: Failed to fetch plugin https://github.com/apache/cordova-plugin-device.git via registry. Probably this is either a connection problem, or plugin spec is incorrect. Check your connection and plugin name/version/URL. Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit code 1 Error output: npm ERR! code 128 npm ERR! Command failed: C:\Program Files\Git\cmd\git.EXE submodule update -q --init --recursive npm ERR! fatal: 'submodule' appears to be a git command, but we were not npm ERR! able to execute it. Maybe git-submodule is broken? npm ERR! npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\almir\AppData\Roaming\npm-cache\_logs\2018-07-16T17_18_04_469Z-debug.log Stack: error properties: undefined at at D:\Dump\cordova-lib\src\plugman\fetch.js:147:37 at _rejected (D:\Dump\cordova-lib\node_modules\q\q.js:864:24) at D:\Dump\cordova-lib\node_modules\q\q.js:890:30 at Promise.when (D:\Dump\cordova-lib\node_modules\q\q.js:1142:31) at Promise.promise.promiseDispatch (D:\Dump\cordova-lib\node_modules\q\q.js:808:41) at D:\Dump\cordova-lib\node_modules\q\q.js:624:44 at runSingle (D:\Dump\cordova-lib\node_modules\q\q.js:137:13) at flush (D:\Dump\cordova-lib\node_modules\q\q.js:125:13) at process._tickCallback (internal/process/next_tick.js:61:11) ```

---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Cordova on windows fails when adding plugin > ------------------------------------------- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows > Reporter: takuya > Assignee: Jesse MacFadyen > Priority: Blocker > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org