From issues-return-95850-archive-asf-public=cust-asf.ponee.io@cordova.apache.org Fri Jul 6 02:24:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A2FF618067B for ; Fri, 6 Jul 2018 02:24:04 +0200 (CEST) Received: (qmail 93898 invoked by uid 500); 6 Jul 2018 00:24:03 -0000 Mailing-List: contact issues-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@cordova.apache.org Received: (qmail 93885 invoked by uid 99); 6 Jul 2018 00:24:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Jul 2018 00:24:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 322CA1A1FBB for ; Fri, 6 Jul 2018 00:24:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id y2hweYlFekDD for ; Fri, 6 Jul 2018 00:24:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 531D05F19D for ; Fri, 6 Jul 2018 00:24:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 86AB0E0361 for ; Fri, 6 Jul 2018 00:24:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 45C5E274F8 for ; Fri, 6 Jul 2018 00:24:00 +0000 (UTC) Date: Fri, 6 Jul 2018 00:24:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@cordova.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CB-14139) Can't run android commands with 32bit Java MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-14139?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D165343= 16#comment-16534316 ]=20 ASF GitHub Bot commented on CB-14139: ------------------------------------- erisu commented on issue #459: CB-14139 android: Add jvmargs flag for custo= m values URL: https://github.com/apache/cordova-android/pull/459#issuecomment-402888= 847 =20 =20 @janpio, sorry for the missing comment. =20 The more I think about it, it's probably better to not add an additional= flag to set the jvmargs. It is a quicker and simpler solution but as menti= oned, it would be harder to remove flag in the future. =20 Using the gradle.properties would be better in the long run.=20 =20 Looking back at the potential issue mentioned above when using the prope= rties file, I think we just need to create a GradlePropertiesConfigParser/W= riter.=20 =20 If the file doesn't exist, we can either - Create the file with our defaults - Continue using the inline command =20 If the file already exists, parse the file to see if they have the defau= lt variables (excluding its value). If the default arguments are missing: - Edit the file with our defaults - Continue using the inline command =20 If they already have the arguments define, then just accept their values= . =20 Also, I feel the amount of 32bit users could probably be very low and th= is would be an edge case. Since the user had a temporary workaround, we mig= ht be able to focus on removing all of the command-line usage in-favor of t= he gradle.properties instead of just jvmargs. =20 The user's temporary workaround did mention setting the environment vari= ables but affecting the whole system. Though testing is needed, it might be= possible to set the variable during execution which shouldn't affect the w= hole system. `_JAVA_OPTIONS=3D-Xmx512m cordova ...`. The only question is i= f the set variable is still set when gradle runs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Can't run android commands with 32bit Java > ------------------------------------------ > > Key: CB-14139 > URL: https://issues.apache.org/jira/browse/CB-14139 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android > Affects Versions: 8.0.0 > Environment: Win 10 Pro x64 > Reporter: misterTi > Assignee: Joe Bowser > Priority: Blocker > > GradleBuilder.js has a buiit-in option org.gradle.jvmargs=3D---Xmx2048m o= n line 59, which prevents it from running on 32bit Java. It always fails wi= th VM heap error. The workaround is to create an environment variable __JAV= A__OPTIONS=3D-Xmx512m, but this then affects the whole system. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org For additional commands, e-mail: issues-help@cordova.apache.org