cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14225) Fix sample namespace Serialize attribute in template/Properties/Default.rd.xml
Date Fri, 27 Jul 2018 00:36:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559089#comment-16559089
] 

ASF GitHub Bot commented on CB-14225:
-------------------------------------

brodybits opened a new pull request #286: CB-14225 fix sample Namespace Serialize attribute
in template/Properties/Default.rd.xml - PROPOSAL WIP
URL: https://github.com/apache/cordova-windows/pull/286
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Original issue
   
   <https://issues.apache.org/jira/browse/CB-14225>
   
   ### Platforms affected
   
   Windows
   
   ### What does this PR do?
   
   - Fix sample Namespace Serialize attribute in `template/Properties/Default.rd.xml`, according
to `Default.rd.xml` in C# UWP project generated by Visual Studio 2017
   
   I also raised <https://github.com/Microsoft/Windows-universal-samples/pull/950> to
apply a similar fix there.
   
   Also related: #284 - fix license text & add link to `template/Properties/Default.rd.xml`
(as reported in <https://issues.apache.org/jira/browse/CB-14224>)
   
   ### What testing has been done on this change?
   
   - Visual inspection
   - check diff
   
   ### Checklist
   
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - ~~Added automated test coverage as appropriate for this change.~~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix sample namespace Serialize attribute in template/Properties/Default.rd.xml
> ------------------------------------------------------------------------------
>
>                 Key: CB-14225
>                 URL: https://issues.apache.org/jira/browse/CB-14225
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-windows
>            Reporter: Chris Brody
>            Assignee: Chris Brody
>            Priority: Minor
>
> If I would generate a new UWP C# project using Visual Studio 2017 and copy the generated
{{Default.rd.xml}} file into {{template\Properties}} then I would see the following diff:
> {code:xml}
> index 7c40ffeb..af00722c 100644
> --- a/template/Properties/Default.rd.xml
> +++ b/template/Properties/Default.rd.xml
> @@ -12,7 +12,7 @@
>      <TypeInstantiation Name="App1.AppClass" Arguments="System.Int32" Activate="Required
Public" />
>      Using the Namespace directive to apply reflection policy to all the types in a particular
namespace
> -    <Namespace Name="DataClasses.ViewModels" Seralize="All" />
> +    <Namespace Name="DataClasses.ViewModels" Serialize="All" />
>  -->
>  <Directives xmlns="http://schemas.microsoft.com/netfx/2013/01/metadata">
> {code}
> I propose to commit this change to the master branch.
> Related:
> * CB-12499 - introduced {{template/Properties/Default.rd.xml}}
> * CB-14224 - proposal to add license text to the header
> * [Microsoft/Windows-universal-samples#950|https://github.com/Microsoft/Windows-universal-samples/pull/950]
- similar proposal for [Microsoft / Windows-universal-samples|https://github.com/Microsoft/Windows-universal-samples]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message