cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14224) template/Properties/Default.rd.xml needs license header
Date Fri, 27 Jul 2018 01:25:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559112#comment-16559112
] 

ASF GitHub Bot commented on CB-14224:
-------------------------------------

shazron commented on a change in pull request #284: [WIP] CB-14224 add license text &
GitHub link to template/Properties/Default.rd.xml - proposal (for discussion)
URL: https://github.com/apache/cordova-windows/pull/284#discussion_r205645861
 
 

 ##########
 File path: template/Properties/Default.rd.xml
 ##########
 @@ -13,6 +13,28 @@
 
     Using the Namespace directive to apply reflection policy to all the types in a particular
namespace
     <Namespace Name="DataClasses.ViewModels" Seralize="All" />
+
 
 Review comment:
   Is this missing the start of the xml comment block?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> template/Properties/Default.rd.xml needs license header
> -------------------------------------------------------
>
>                 Key: CB-14224
>                 URL: https://issues.apache.org/jira/browse/CB-14224
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-windows
>            Reporter: Chris Brody
>            Assignee: Chris Brody
>            Priority: Minor
>
> Running {{coho audit-license-headers -r windows}} gives a message that {{template/Properties/Default.rd.xml}}
is missing the license header. From a quick search I found {{Default.rd.xml}} in [Microsoft
/ Windows-universal-samples / SharedContent / cs / Default.rd.xml (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml]
which is exactly the same except for a {{http}} link that was updated to {{https}} _(update:
old {{http}} link in GitHub, no need to update this one)_. I would like to propose the following
changes:
>  * -Updated {{https}} link from [Microsoft / Windows-universal-samples / SharedContent
/ cs / Default.rd.xml (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml]-
>  * Include license text from [Microsoft / Windows-universal-samples / LICENSE (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/LICENSE]
(with left alignment fixed)
>  * Link to [Microsoft / Windows-universal-samples / SharedContent / cs / Default.rd.xml
(github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml]
in {{template/Properties/Default.rd.xml}}
> _Additional notes:_
> - _{{template/Properties/Default.rd.xml}} was introduced in CB-12499._
> - _I raised [Microsoft/Windows-universal-samples#949|https://github.com/Microsoft/Windows-universal-samples/pull/949]
to cleanup (and rename) its LICENSE file. This may influence the exact LICENSE text we should
include in {{template/Properties/Default.rd.xml}}._
> - _Another fix to {{template/Properties/Default.rd.xml}} is proposed in CB-14225_



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message