cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14224) template/Properties/Default.rd.xml needs license header
Date Fri, 27 Jul 2018 00:28:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559077#comment-16559077
] 

ASF GitHub Bot commented on CB-14224:
-------------------------------------

brodybits opened a new pull request #285: CB-14224 Default.rd.xml updates (6.0.x patch)
URL: https://github.com/apache/cordova-windows/pull/285
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Original issue
   
   <https://issues.apache.org/jira/browse/CB-14224>
   
   ### Platforms affected
   
   Windows
   
   ### What does this PR do?
   
   Proposed `template/Properties/Default.rd.xml` updates in 6.0.x patch release, as rebased
& squashed from #284:
   - add MIT license text from <https://github.com/Microsoft/Windows-universal-samples>,
with left aligment fixed
   - add link to <https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml>
   
   As I said in #284 I think this is desired to satisfy the Apache RAT tool (used by `coho
audit-license-headers`). Alternative may be to add an exception for this file but I think
it would be better to follow the standard Apache procedure if possible.
   
   ### What testing has been done on this change?
   
   I verified that `coho audit-license-headers -r windows` with these changes does not show
the missing license header any more.
   
   ### Checklist
   
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - ~~Added automated test coverage as appropriate for this change.~~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> template/Properties/Default.rd.xml needs license header
> -------------------------------------------------------
>
>                 Key: CB-14224
>                 URL: https://issues.apache.org/jira/browse/CB-14224
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-windows
>            Reporter: Chris Brody
>            Assignee: Chris Brody
>            Priority: Minor
>
> Running {{coho audit-license-headers -r windows}} gives a message that {{template/Properties/Default.rd.xml}}
is missing the license header. From a quick search I found {{Default.rd.xml}} in [Microsoft
/ Windows-universal-samples / SharedContent / cs / Default.rd.xml (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml]
which is exactly the same except for a {{http}} link that was updated to {{https}} _(update:
old {{http}} link in GitHub, no need to update this one)_. I would like to propose the following
changes:
>  * -Updated {{https}} link from [Microsoft / Windows-universal-samples / SharedContent
/ cs / Default.rd.xml (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml]-
>  * Include license text from [Microsoft / Windows-universal-samples / LICENSE (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/LICENSE]
(with left alignment fixed)
>  * Link to [Microsoft / Windows-universal-samples / SharedContent / cs / Default.rd.xml
(github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml]
in {{template/Properties/Default.rd.xml}}
> _Additional notes:_
> - _{{template/Properties/Default.rd.xml}} was introduced in CB-12499._
> - _I raised [Microsoft/Windows-universal-samples#949|https://github.com/Microsoft/Windows-universal-samples/pull/949]
to cleanup (and rename) its LICENSE file. This may influence the exact LICENSE text we should
include in {{template/Properties/Default.rd.xml}}._
> - _Another fix to {{template/Properties/Default.rd.xml}} is proposed in CB-14225_



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message