cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
Date Tue, 17 Jul 2018 15:27:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16546785#comment-16546785
] 

ASF GitHub Bot commented on CB-14211:
-------------------------------------

raphinesse commented on issue #627: CB-14211: Run test suite in PowerShell and cmd.exe
URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-405623257
 
 
   While I think that it's a good idea to test in different shells, this doubles the amount
of jobs, right? Currently, AppVeyor tests take *very* long already. Since the jobs are only
executing sequentially and some of our tests are awfully slow, it takes about **one hour**
for them to finish. So with these changes I'm expecting a runtime of about **two hours**.
:disappointed: 
   
   IMO, we should only increase the number of jobs if it has no drastic impact on the overall
build time.
   
   I'm currently working on cleaning up the biggest runtime-offenders, so that we hopefully
can reduce our test duration drastically as a next step. However, I suspect these changes
are still a few weeks from being ready to land. Right now the tests take about 480s on my
machine with the two biggest offenders amounting to 305s. Say I can reduce the overall run
time by 50% that would still leave us with a 10 minute run time per job on the CI. Which would
still be 30 minutes without this change or 60 minutes with it. Which I would still be inclined
to avoid.
   
   I guess what I'm trying to say is: I would very much prefer to find some way to test this
with less impact on the CI run time. Like excessive unit tests for `superspawn` for example.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
> ---------------------------------------------------------------------
>
>                 Key: CB-14211
>                 URL: https://issues.apache.org/jira/browse/CB-14211
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-lib
>            Reporter: Oliver Salzburg
>            Priority: Major
>
> I thought it could be useful to run the test suite in both shells, just to be safe.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message