cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14194) Prepare fails when using scoped packages
Date Thu, 05 Jul 2018 15:33:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533813#comment-16533813
] 

ASF GitHub Bot commented on CB-14194:
-------------------------------------

oliversalzburg opened a new pull request #625: CB-14194: Don't cut off scope from package
identifier
URL: https://github.com/apache/cordova-lib/pull/625
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   All
   
   ### What does this PR do?
   When looking for the installation folder for a scoped npm package, include the scope in
the search. Otherwise it will always fail.
   
   ### What testing has been done on this change?
   I ran `npm test` and I built (`cordova prepare`) our own app with this code.
   
   ### Checklist
   - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
   - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Prepare fails when using scoped packages
> ----------------------------------------
>
>                 Key: CB-14194
>                 URL: https://issues.apache.org/jira/browse/CB-14194
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-lib
>    Affects Versions: Master
>            Reporter: Oliver Salzburg
>            Priority: Major
>
> When adding a plugin to a project, cordova will fail if the plugin is hosted under an
npm scope.
> The scope is cut off when searching for the installation folder on disk:
> ```
> Discovered plugin "@fairmanager/cordova-plugin-push" in config.xml. Adding it to the
project
> Failed to restore plugin "@fairmanager/cordova-plugin-push" from config.xml. You might
need to try adding it again. Error: Cannot find plugin.xml for plugin "cordova-plugin-push".
Please try adding it again.
> ```



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message