cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14190) Double click `<select>` element causes app to exit.
Date Wed, 04 Jul 2018 14:52:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532845#comment-16532845
] 

ASF GitHub Bot commented on CB-14190:
-------------------------------------

iainconnor opened a new pull request #275: CB-14190: (windows) Fix bug where double clicking
`<select>` exits app
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/275
 
 
   Double clicking on `<select>` elements will no longer exit the application.
   
   ### Platforms affected
   
   * Windows.
   
   ### What does this PR do?
   
   Previously, there was code which I assume was meant to detect a click outside the webview
(and on the browser wrapper), and close the webview if such a click occurs. This makes sense
if the webview is treated like a popup, but the code did not check if the target of the click
was the webview itself. For whatever reason, double clicking a `<select>` element triggered
this behaviour, incorrectly closing the webview when the user is trying to interact with it.
   
   ### What testing has been done on this change?
   
   * Tested that double clicking a `<select>` element no longer triggers the exit event.
   * Tested that a non-fullscreen inappbrowser still triggers the exit event if clicked outside
of.
   
   ### Checklist
   - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
   - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [X] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Double click `<select>` element causes app to exit.
> ---------------------------------------------------
>
>                 Key: CB-14190
>                 URL: https://issues.apache.org/jira/browse/CB-14190
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-plugin-inappbrowser, cordova-windows
>    Affects Versions: 3.0.0
>            Reporter: Iain Connor
>            Assignee: Jesse MacFadyen
>            Priority: Minor
>
> In Windows, create an inappbrowser and browse somewhere with target not `_system` or
`_self` or empty.
> Find a `<select>` element and double click it.
> Expected behaviour:
> First click expands `<select>` dropdown by showing `<option>`s.
> Second click is ignored or chooses `<option>` under cursor, if there is one.
> Actual behaviour:
> Second click exits the inappbrowser.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message