cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS
Date Tue, 03 Jul 2018 11:51:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531245#comment-16531245
] 

ASF GitHub Bot commented on CB-14187:
-------------------------------------

wvengen opened a new pull request #274: CB-14187: (ios) Change the InAppBrowser to allow custom
schemes
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/274
 
 
   …Auth
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   - iOS
   
   ### What does this PR do?
   
   Implements [CB-14187](https://issues.apache.org/jira/browse/CB-14187), which adds support
for the `AllowedSchemes` preference and `customscheme` event for iOS.
   
   ### What testing has been done on this change?
   
   Tested on an iPhone 5SE running iOS 11.4.
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [x] Added automated test coverage as appropriate for this change: as [CB-14013](https://issues.apache.org/jira/browse/CB-14013)
(https://github.com/apache/cordova-plugin-inappbrowser/pull/263) did not include additional
tests, I expect it to be unnecessary here as well.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --------------------------------------------------
>
>                 Key: CB-14187
>                 URL: https://issues.apache.org/jira/browse/CB-14187
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: cordova-plugin-inappbrowser
>    Affects Versions: 3.0.0
>            Reporter: wvengen
>            Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes preference. This
only works on Android, however. It would be very useful to have this on iOS (and other platforms)
as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message