cordova-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-14185) Do not publish .md5 checksum files
Date Tue, 03 Jul 2018 03:57:00 GMT

    [ https://issues.apache.org/jira/browse/CB-14185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530788#comment-16530788
] 

ASF GitHub Bot commented on CB-14185:
-------------------------------------

shazron closed pull request #175: CB-14185: (tooling) Skip md5 use for create-archive
URL: https://github.com/apache/cordova-coho/pull/175
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.gitignore b/.gitignore
index 70823f2..a2f7eec 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,3 +5,5 @@ apache-rat-0.12
 node_modules
 .idea
 **/*.swp
+
+.DS_Store
diff --git a/src/create-verify-archive.js b/src/create-verify-archive.js
index 1f5d5d4..31fe7d3 100644
--- a/src/create-verify-archive.js
+++ b/src/create-verify-archive.js
@@ -45,7 +45,7 @@ exports.createCommand = function * (argv) {
             type: 'boolean'
         })
         .options('sign', {
-            desc: 'Whether to create .asc, .md5, .sha files (defaults to true)',
+            desc: 'Whether to create .asc, .sha512 files (defaults to true)',
             type: 'boolean',
             default: 'true'
         })
@@ -55,7 +55,7 @@ exports.createCommand = function * (argv) {
         });
     opt = flagutil.registerHelpFlag(opt);
     var argv = opt // eslint-disable-line
-        .usage('Creates a .zip, .asc, .md5, .sha for a repo at a tag or hash.\n' +
+        .usage('Creates a .zip, .asc, .sha for a repo at a tag or hash.\n' +
                'Refer to ' + settingUpGpg + ' for how to set up gpg\n' +
                '\n' +
                'Usage: $0 create-archive [--tag tagname] [--sign] --repo=name [-r repos]
--dest cordova-dist-dev/CB-1111')
@@ -125,7 +125,6 @@ function * createArchive (repo, tag, outDir, sign) {
     print('Created archive: ' + outPath);
     if (sign) {
         yield executil.execHelper(executil.ARGS('gpg --armor --detach-sig --output', outPath
+ '.asc', outPath), false, false);
-        fs.writeFileSync(outPath + '.md5', (yield computeHash(outPath, 'MD5')) + '\n');
         fs.writeFileSync(outPath + '.sha512', (yield computeHash(outPath, 'SHA512')) + '\n');
     }
     return outPath;
@@ -136,7 +135,7 @@ exports.createArchive = createArchive;
 exports.verifyCommand = function * () {
     var opt = flagutil.registerHelpFlag(optimist);
     var argv = opt
-        .usage('Ensures the given .zip files match their neighbouring .asc, .md5, .sha files.\n'
+
+        .usage('Ensures the given .zip files match their neighbouring .asc, .sha512 files.\n'
+
                'Refer to ' + settingUpGpg + ' for how to set up gpg\n' +
                '\n' +
                'Usage: $0 verify-archive a.zip b.zip c.zip')
@@ -171,10 +170,7 @@ function * verifyArchive (archive) {
     if (result === null) {
         apputil.fatal('Verification failed. You may need to update your keys. Run: curl "https://dist.apache.org/repos/dist/release/cordova/KEYS"
| gpg --import');
     }
-    var md5 = yield computeHash(archive, 'MD5');
-    if (extractHashFromOutput(fs.readFileSync(archive + '.md5', 'utf8')) !== md5) {
-        apputil.fatal('MD5 does not match.');
-    }
+
     var sha = yield computeHash(archive, 'SHA512');
     var archiveFileName = archive + '.sha512';
     var oldArchiveFileName = archive + '.sha';


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Do not publish .md5 checksum files
> ----------------------------------
>
>                 Key: CB-14185
>                 URL: https://issues.apache.org/jira/browse/CB-14185
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-coho
>            Reporter: Jesse MacFadyen
>            Assignee: Jesse MacFadyen
>            Priority: Major
>
> Policy here:  [https://www.apache.org/dev/release-distribution#sigs-and-sums]
> related CB-13319



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


Mime
View raw message